-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triggering of haptic and audio feedback during cursor movement on spacebar swipe #1035
base: main
Are you sure you want to change the base?
Conversation
…on spacebar swipe
Added methods to customize for cursor haptic feedback using TEXT_HANDLE_MOVE and CLOCK_TICK (API <27)
I have now added methods to make the call using TEXT_HANDLE_MOVE and remove audiofeedback. |
viewToPerformHapticFeedbackOn.performHapticFeedback( | ||
HapticFeedbackConstants.TEXT_HANDLE_MOVE, | ||
HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING); | ||
}else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}else { | |
} else { |
Does this work for everyone except me? |
I actually wrote some haptic mods a while ago for my homebrew. Those are newer API constants, so they do nothing on newer versions. I believe they have IDE warnings because of that. I've not looked at the code in a while, but there should probably be a central place haptics handling that addresses all the version differences and stuff. |
Actually there were a few |
I added a line that triggers the default haptic and audio feedback when the cursor is getting moved by swiping over the spacebar.
If keypress sound is enabled the sound might get spammed a bit.
The implementation works well for me like this but I didnt fully understand the method I modified so maybe this doesnt make sense in every case.
Issue 381 also requested this.