Skip to content

Allow resizing emoji and clipboard views #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Allow resizing emoji and clipboard views #337

merged 6 commits into from
Dec 20, 2023

Conversation

Helium314
Copy link
Owner

Came up during #321, but there are still too many issues to include this in the otherwise working PR.

Maybe the whole PR will be scrapped, maybe only the second commit.
First commit makes the resize roughly work, but the suggestion strip is ignored, and the emoji tab strip appears at smaller scale below the suggestion strip. Resizing does not affect emoji keyboard internals, and always switches to main keyboard.
Second commit tries to set a combined suggestion strip / emoji tab strip, but that does not work well, the emoji tab strip still gets resized for some reason.

There are some more issues that are not mentioned here.

@Helium314 Helium314 added this to the Release 1.0 milestone Dec 19, 2023
@Helium314
Copy link
Owner Author

Added to milstone. This needs to be implemented or scrapped.

@Helium314
Copy link
Owner Author

Helium314 commented Dec 19, 2023

Adjusted attempt, now based on the recent changes to colors.
This is basically the first 2 commits and some fixes.

Emojis now only change size with height scale, otherwise is stays constant when changing bottom padding, adding number row or using one-handed mode.

Issues:

  • clipboard ABC key doesn't resize with one-handed mode (not necessary, but looks slightly awkward)
  • suggestion strip in clipboard view looks a little out of place
    • what to use as replacement? Some toolbar keys?

@Helium314 Helium314 marked this pull request as ready for review December 20, 2023 17:48
@Helium314
Copy link
Owner Author

I guess this is ok now.
The clipboard things (top strip and ABC key) will be addressed in a separate commit, possibly unifying bottom key bar with emoji view.

@Helium314 Helium314 merged commit 9f21f54 into new Dec 20, 2023
@Helium314 Helium314 deleted the adjust_view_again branch January 28, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant