Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI: Add Python 3.8 #1

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Travis CI: Add Python 3.8 #1

merged 2 commits into from
Nov 28, 2019

Conversation

cclauss
Copy link

@cclauss cclauss commented Nov 1, 2019

No description provided.

@Hellzed Hellzed self-requested a review November 11, 2019 12:00
@Hellzed
Copy link
Owner

Hellzed commented Nov 11, 2019

@cclauss Your PR is hit by the following issue, so mypy check fails: python/mypy#2427
You need to add a # type: ignore here: https://github.com/cclauss/aiodataloader-next/blob/patch-1/aiodataloader.py#L62

I'm pretty sure that's just the latest version of mypy moving warnings around (in this case, the one silenced here: https://github.com/Hellzed/aiodataloader-next/blob/master/aiodataloader.py#L67 )

I'll be happy to merge your CI changes!

@Hellzed Hellzed merged commit eb0b2ea into Hellzed:master Nov 28, 2019
@cclauss cclauss deleted the patch-1 branch November 28, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hellzed Hellzed Awaiting requested review from Hellzed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @Hellzed