Migrated changes that apply to loading model and optimizer #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mammoth/models/model_saver.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import os | |||
| from collections import deque | |||
| from glob import glob | |||
| from collections import deque, defaultdict | |||
There was a problem hiding this comment.
defaultdict is imported but not used..?
| @@ -332,6 +350,9 @@ def build_task_specific_model( | |||
| if uses_adapters(model_opts): | |||
| logger.info('Creating adapters...') | |||
| create_all_adapters(nmt_model, model_opts, task_queue_manager) | |||
| if checkpoint: | |||
| # TODO: plug in properly | |||
There was a problem hiding this comment.
this TODO probably worth creating another issue
added 2 commits
February 13, 2024 21:40
josephattieh
requested review from
TimotheeMickus and
jrvc
and removed request for
jrvc
The linting errors have been fixed and the feature has been tested! |
jrvc
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to load model and optimizer from checkpoint.
This does not reload the data state.