CBIGR Terms of Use #11
Conversation
laemtl
commented
Oct 19, 2020
•
laemtl
commented
- add a Terms of Use modal
- the modal displays on the first visit
- a menu item can display the modal at any time
htdocs/bootstrap/css/custom-css.css
Outdated
| @@ -831,3 +831,8 @@ legend { | |||
| font-size: 14px; | |||
| color: #064785; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@HenriRabalais do we not already have css for modals ?
There was a problem hiding this comment.
Without this change the modal does not have a scroll bar. I think a scroll bar is useful because this modal does have a lot of text so the Accept button is hidden otherwise.
There was a problem hiding this comment.
then my question becomes, is this gonna affect the modals in the biobank ??? and im pretty sure those have scrolling
There was a problem hiding this comment.
@ridz1208 yeah, the modal windows in the Biobank does have an overflow: scroll property. This is styled directly into the jsx component though and is not done through the css class structure.
There was a problem hiding this comment.
how come its not working for @laemtl ??
There was a problem hiding this comment.
@ridz1208 because this PR doesn't make use of the jsx/Modal.js component.
There was a problem hiding this comment.
I can take care of the reactification once the priorities have been dealt with. For now, I have integrated my style changes directly into the html to avoid conflicts with the react component.
laemtl
force-pushed
the
2020-10-19-terms-uses
branch
from
c703da3 to
546fa40
Compare
|
@laemtl this seems to be doing something that could easily be reactified and turned into an override... I will leave it as is for now cause better having this than nothing This PR should not be merged into this Branch a new branch will be created for the open version |
|
@ridz1208 Do you have some potential ideas to turn this into an override? Is there a system in LORIS to add a widget into all pages? |
|
@laemtl maybe adding it to the request account logic (instead of on first visit, you would have to agree to the terms when you request your user... but its not a priority now) |
|
One problem I see with this approach is that once agreed, the Terms of Use can't be accessed anymore. |
|
true, the other potential issue is if we go OPEN for real, there will be no more request account. thats why for now lets leave it as is |
laemtl
force-pushed
the
2020-10-19-terms-uses
branch
from
546fa40 to
56416d8
Compare
laemtl
force-pushed
the
2020-10-19-terms-uses
branch
from
56416d8 to
2277664
Compare
