Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize error code #50

Open
make-github-pseudonymous-again opened this issue Feb 26, 2021 · 4 comments
Open

Customize error code #50

make-github-pseudonymous-again opened this issue Feb 26, 2021 · 4 comments

Comments

@make-github-pseudonymous-again

Currently fixpack yields a non-zero error code as soon as it modifies the package.json file. Would it be possible to add a flag so that it only yields a non-zero error code when required fields are missing? My current workaround is to run fixpack twice (fixpack || fixpack)

@make-github-pseudonymous-again
Copy link
Author

The behavior has been recently altered in e4c9e66 but that is still not what I am after.

@dls314
Copy link

dls314 commented Mar 3, 2021

I'm running fixpack across a monorepo using Lerna and it would be very helpful to have the option to continue after modifying the package.json.

make-github-pseudonymous-again added a commit to make-github-pseudonymous-again/sak that referenced this issue Mar 8, 2021
@daiyam
Copy link

daiyam commented Aug 9, 2021

I agree with @make-github-pseudonymous-again.
When the package is been fixed, it still should return 0.

@andrewtran1995
Copy link

Opened up a PR to address this, feedback on the flag would be appreciated! #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants