Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken tests for multiple nested tags #44

Closed
wants to merge 2 commits into from
Closed

Add broken tests for multiple nested tags #44

wants to merge 2 commits into from

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Mar 22, 2021

When self-encoding

<div>Testing <strong>multiple <em>nested</em></strong> tags</div>

the result is unexpectedly

<div>Testing <strong>multiple <em>nested</em> tags</strong></div>

This can be related to #40

Fixing this issue in addition to #43 can unblock i18next/react-i18next#1283

next-i18next has ≈1M weekly downloads from npm, which can give this library quite a boost in its popularity!

@kachkaev
Copy link
Contributor Author

kachkaev commented Apr 1, 2021

@HenrikJoreteg what are your thoughts on this one? Happy to try fixing the lib if you help me with some directions. Feel free to push to this PR or recycle my commit if you would like to try the fix too!

@kachkaev
Copy link
Contributor Author

kachkaev commented Apr 1, 2021

Actually, I think we have the solution! I just copy-pasted a fix from #41 and my tests passed! So all we need is to merge #41! 🎉

Closing.

@kachkaev kachkaev closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant