Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce respectWhitespace parse option #45

Closed
wants to merge 1 commit into from
Closed

introduce respectWhitespace parse option #45

wants to merge 1 commit into from

Conversation

adrai
Copy link
Collaborator

@adrai adrai commented Apr 6, 2021

@adrai
Copy link
Collaborator Author

adrai commented Apr 11, 2021

@HenrikJoreteg any reaction from your side would help a lot here:
i18next/react-i18next#1275 (comment)
i18next/react-i18next#1283 (comment)

Copy link
Owner

@HenrikJoreteg HenrikJoreteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @adrai. I just have one comment, really.

@HenrikJoreteg
Copy link
Owner

I'm tempted to just do a major version bump and change the behavior to always preserve it, what do you think?

@adrai
Copy link
Collaborator Author

adrai commented Apr 11, 2021

I was thinking the same when creating the PR, but did not want to break the existing behaviour.
If you want to create a major and always respect the whitespaces it's even better ;-)

@adrai
Copy link
Collaborator Author

adrai commented Apr 11, 2021

So let's close this PR

@adrai adrai closed this Apr 11, 2021
@adrai adrai mentioned this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants