Catch exceptions during jade.compile and invoke callback #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle syntax errors in jade templates correctly and make sure the callback is invoked. Otherwise an error is thrown and crashes the process.
|
Thanks @klausbayrhammer, this looks great. It looks like the CI tests failed for a different reason which I'll fix separately before publishing. |
lukekarrys
added a commit
that referenced
this pull request
Nov 5, 2015
…ck-on-jade-syntax-errors Catch exceptions during jade.compile and invoke callback
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle syntax errors in jade templates correctly and make sure the callback is invoked. Otherwise an error is thrown and crashes the process.