Minor improvements #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added type hints to the function signatures of the get_shape() and get_dtype() methods to make the return types explicit. Changed the condition in the get_thumb() method from if save_path != None to if save_path is not None for better readability. Improved the condition in the get_thumb() method by checking for None instead of checking the truthiness of save_path. This is a more explicit check.
|
❌ Build NanoPyx 356 failed (commit f821d632b9 by @ajinkya-kulkarni) |
|
❌ Build NanoPyx 359 failed (commit f821d632b9 by @ajinkya-kulkarni) |
|
Strange - I don't understand why did it fail? The changes I made should not affect the tests ideally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints to the function signatures of the get_shape() and get_dtype() methods to make the return types explicit. Changed the condition in the get_thumb() method from if save_path != None to if save_path is not None for better readability. Improved the condition in the get_thumb() method by checking for None instead of checking the truthiness of save_path. This is a more explicit check.