Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*rodex_sendmail script command attach with 0 item amount can't delete mail #2897

Closed
AnnieRuru opened this issue Nov 13, 2020 · 1 comment · Fixed by #2901
Closed

*rodex_sendmail script command attach with 0 item amount can't delete mail #2897

AnnieRuru opened this issue Nov 13, 2020 · 1 comment · Fixed by #2901
Assignees
Labels
component:core:scriptengine Affecting the script engine or the script commands status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Comments

@AnnieRuru
Copy link
Contributor

Describe the bug
when using script command *rodex_sendmail, send with item amount 0,
will cause the mail cannot retrieve the item or delete the mail

SELECT * FROM rodex_items;
delete from rodex_items where amount = 0 and id > -1;

I have to manually remove like this

To Reproduce

prontera,155,185,5	script	kjsdfhks	1_F_MARIA,{
	rodex_sendmail getcharid(CHAR_ID_CHAR), "someone", "title", "body\r leg", 0, Apple, 0;
}

Expected behavior
this script command should put some check with item amount with 0

System specs (please complete the following information):

  • OS: Windows 10 pro 64-bit
  • Hercules Version: latest (always pull latest git)
  • Packet version: 20190530
  • Mode: Renewal
  • Client type: 2019-05-30aRagexeRE
  • Branch: Main

Plugins used or source modifications
.... nothing concern here

Additional context

@Kenpachi2k13
Copy link
Member

Well... Again missing data evaluation.
Neither BUILDIN(rodex_sendmail) nor BUILDIN(rodex_sendmail2) checks the passed item amount for validity.

@Kenpachi2k13 Kenpachi2k13 added component:core:scriptengine Affecting the script engine or the script commands status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed labels Nov 14, 2020
@Kenpachi2k13 Kenpachi2k13 linked a pull request Nov 14, 2020 that will close this issue
3 tasks
@Kenpachi2k13 Kenpachi2k13 self-assigned this Nov 14, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.11.16 milestone Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core:scriptengine Affecting the script engine or the script commands status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants