Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some data evaluation to the RODEX send mail script commands #2901

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Add some data evaluation to the RODEX send mail script commands #2901

merged 3 commits into from
Nov 16, 2020

Conversation

Kenpachi2k13
Copy link
Member

Pull Request Prelude

Changes Proposed

  • Add check for receiver ID is in valid range to rodex_sendmail_sub().
  • Add check for valid item amount to BUILDIN(rodex_sendmail).
  • Add check for valid item amount to BUILDIN(rodex_sendmail2).

Issues addressed: #2897 #2898

@Kenpachi2k13 Kenpachi2k13 added type:bug Issue is a bug or describes an incorrect behavior that should be fixed status:code-review Awaiting code review component:core:scriptengine Affecting the script engine or the script commands labels Nov 14, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.11.16 milestone Nov 14, 2020
@Kenpachi2k13 Kenpachi2k13 self-assigned this Nov 14, 2020
This was linked to issues Nov 14, 2020
*rodex_sendmail script command attach with 0 item amount can't delete mail #2897
Closed
*rodex_sendmail script command can send with non-existent char ID #2898
Closed
AnnieRuru
AnnieRuru requested changes Nov 14, 2020
View reviewed changes
src/map/script.c Outdated Show resolved Hide resolved
AnnieRuru
AnnieRuru requested changes Nov 14, 2020
View reviewed changes
src/map/script.c Show resolved Hide resolved
src/map/script.c Show resolved Hide resolved
src/map/script.c Show resolved Hide resolved
@MishimaHaruna MishimaHaruna merged commit e13bc68 into HerculesWS:master Nov 16, 2020
@Kenpachi2k13 Kenpachi2k13 deleted the rodex_data_evaluation branch November 17, 2020 06:50
@MrKeiKun MrKeiKun mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

@hemagx hemagx Awaiting requested review from hemagx

@skyleo skyleo Awaiting requested review from skyleo

@Asheraf Asheraf Awaiting requested review from Asheraf

@AnnieRuru AnnieRuru Awaiting requested review from AnnieRuru

Assignees

@Kenpachi2k13 Kenpachi2k13

Labels
component:core:scriptengine Affecting the script engine or the script commands status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Milestone
Release v2020.11.16
4 participants
@Kenpachi2k13 @4144 @MishimaHaruna @AnnieRuru