Show 1 Hp/Sp regen when sitting

[AnnieRuru]

Describe the bug
https://herc.ws/board/topic/19152-show-1-regen-hpsp-how-to-remove-it/#comment-99462

To Reproduce

1. @heal -100
2. sit
3. profit

Expected behavior
don't show the '1' '1' '1' when sitting

Screenshots

System specs (please complete the following information):

• OS: Windows 10 pro 64-bit
• Hercules Version: latest (always pull latest git)
• Packet version: 20190530
• Mode: Renewal
• Client type: 2019-05-30aRagexeRE
• Branch: Main

Plugins used or source modifications
many people has reproduce this issue, so don't need to tell isn't it ?

Additional context
I actually also reproduce this issue since 2 months ago, just didn't bother to report this

the answer is on the forum, but dev needs to take a look

[Daraen1]

I am the author of the initial problem. My teammate and I found the solution it is available on the forum directly as AnnieRuru says.
I also specify that the problem happened on 2018-04-18bRagexeRE and that I personally use the pre-renewal mechanism and that I also have the latest version of Hercules

[dastgirp]

I noticed this happen normal regen as well, not only when sitting.

[Daraen1]

Yes, but by changing the original code
if (regen->skill != NULL) { regen->skill->hp = cap_value(regen->skill->hp, 1, INT16_MAX); regen->skill->sp = cap_value(regen->skill->sp, 1, INT16_MAX); } if (regen->sitting != NULL) { regen->sitting->hp = cap_value(regen->sitting->hp, 1, INT16_MAX); regen->sitting->sp = cap_value(regen->sitting->sp, 1, INT16_MAX); }
to
if (regen->skill != NULL) { regen->skill->hp = cap_value(regen->skill->hp, 0, INT16_MAX); regen->skill->sp = cap_value(regen->skill->sp, 0, INT16_MAX); }
if (regen->sitting != NULL) { regen->sitting->hp = cap_value(regen->sitting->hp, 0, INT16_MAX); regen->sitting->sp = cap_value(regen->sitting->sp, 0, INT16_MAX); }

In hercules / src / map / status.c
The problem will be corrected for both, i.e. sitting and standing