Horror Toy Factory Instance implementation based on official conversion. #1539

AtlantisRO · 2017-01-02T07:25:02Z

Pull Request Prelude

I have followed proper Hercules code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This is a conversion from the script provided by esu1214 from Hercules' Boards in a collaboration with @Ridley8819 and @AtlantisRO, with the translation from Traditional Chinese language by Steph.

Affected Branches: master

Issues addressed: #240 Episode 14.2 : Eclage (Part of TODO list of updates)

Known Issues and TODO List

Requires to update npctalk script command to not show npc name by default (Pull Request Script commands Update #1571).
Requires implementation of unit controlling script commands (Pull Request Implementation of unit controlling script commands. #1584).
Requires skills 716 and 719 for Spectrum Celine and Hidden Mob monsters.

This change is

hemagx · 2017-01-02T07:39:44Z

Such great release, what's missing in source parts other than those two commands? (possible description?).
i will work on this to merge asap

Ridley8819 · 2017-01-02T07:45:27Z

@hemagx
Missing is the setunitdata/getunitdata and those skills he mentioned. But even without them it's in a playable state

hemagx · 2017-01-02T07:51:22Z

possible description?

iRagno · 2017-01-02T08:29:16Z

Script commands actually is like the ones from AnnieRuru: http://herc.ws/board/topic/11097-setmobdata-getmobdata/ to check and adjust monsters hp according to the script.

And the skills are the ones commented on mob_skill_db.txt

Asheraf · 2017-01-02T11:22:58Z

Just to mention somethings

the npc #fac1bs should have no visible name (issue npctalk with empty NPC_NAME #1523 ).
the npc Worker#1 should stop you from doing anything while he is talking (*pcblock).
for npc Gold Hand Birina#1 i would suggest using this one here.
We still miss some kind of mob mod so some monsters won't attack you if you're disguising as xmas cookie.
Last thing why not iRO Translation?

Asheraf · 2017-01-02T11:30:09Z

db/re/item_db.conf

+	Loc: 136
+	EquipLv: 100
+	Script: <"
+		bonus bMaxSP ,-300;


Asheraf · 2017-01-02T11:30:38Z

db/re/item_db.conf

+	Type: 0
+	Weight: 20
+	BuyingStore: true
+	Script: <" itemheal 0, rand(80,100); ">


Asheraf · 2017-01-02T11:30:46Z

db/re/item_db.conf

+	Type: 0
+	Weight: 20
+	BuyingStore: true
+	Script: <" itemheal rand(800,1000), 0; ">


Asheraf · 2017-01-02T11:31:48Z

db/re/item_db.conf

+	Weight: 10
+	Loc: 64
+	Script: <"
+		.@r = getrefine();


no need to use a variable here check #1441

Asheraf · 2017-01-02T11:32:05Z

db/re/item_db.conf

+	Loc: 64
+	Script: <"
+		.@r = getrefine();
+		bonus2 bAddRace, RC_All, 1+.@r/2;


Asheraf · 2017-01-02T11:32:10Z

db/re/item_db.conf

+	Script: <"
+		.@r = getrefine();
+		bonus2 bAddRace, RC_All, 1+.@r/2;
+		bonus bMatkRate, 1+.@r/2;


Asheraf · 2017-01-02T11:32:17Z

db/re/item_db.conf

+		.@r = getrefine();
+		bonus2 bAddRace, RC_All, 1+.@r/2;
+		bonus bMatkRate, 1+.@r/2;
+		bonus bMaxHPrate, -2-2*(.@r/2);


Asheraf · 2017-01-02T11:32:37Z

db/re/item_db.conf

+	Loc: 2
+	Script: <"
+		bonus bMatkRate, 10;
+		bonus5 bAutoSpell, NPC_CRITICALWOUND, 3, 50+5*(getrefine()/3), BF_MAGIC, 1;


Ridley8819 · 2017-01-02T18:07:30Z

@hemagx
Skill 716 - NPC_MAXPAIN is a skill of HIDDEN_MOB7with ID 3038.
I don't know why Celine doesn't have that skill by herself. Instead this mob has it. Idon't have much info of maxpain, all I found was a korean patch note of 2014/04/02 where it states something like "Fixed a bug with the damage reflection of the Skill Max Pain [NPC exclusive]". Another thing I found is, that it deals damage dealt to her (Celine) back in AOE

Skill 719 - NPC_HELLBURNING
"Ice Mine, Flame Cross, and Hell Burning is said to be AoE's that stay on the ground for a while."
"This skill spam ~ anopheles in line x 4 w,e,n,s and effect firewall during xx seconds you can see in most videos at youtube"

https://youtu.be/jHtsfjvNXm8?t=107
at 1:47 you can see those fire walls appearing.

I have no idea of formulas or anything. But iRO added a site on their wiki for HTF on 15th Dec. Maybe they gonna add it and probably add skill description and formulas too.

iRagno · 2017-01-03T08:39:13Z

for npc Gold Hand Birina#1 i would suggest using this one here.

That part was more a conversion more stricted to original script, it almost hasn't improvement, not as for instance. I guess it's better to improve it like on example. However, the usage of disable_items it is not needed, since that npc doesn't make any evaluation that involves equiped gears. Put them is meaningless, as well as don't puting it (or puting it commenting it with a note pointing that).

Last thing why not iRO Translation?

About translation, this text was translated some days before or by the same days of implementation of htf on iRO from chinese by a person who naturally speak chinese (as far as I know). I think this are well doned (as many other scripts that has also custom translation before were implemented by iRO).

I would not mind to gather text from iRO, but I don't have the characters to met the instance requierement.

As for the spaces, it will be fixed.

Asheraf · 2017-01-03T09:32:13Z

@ragn0 I could give you the texts from iRO since i already gathered them when they released the instance.

Ridley8819 · 2017-01-03T09:53:27Z

iRO translation is always the last option to follow. We use it on some other scripts but in most cases it has issues with grammar and more.

matheus00123 · 2017-01-07T19:24:18Z

Sorry my english I'm using google translator

Is quest_db missing?
Because everything is correct more at the time of initiating the instance accuses that the quest does not exist in db.

iRagno · 2017-01-08T05:33:38Z

Yes, it was missed quest_db entryes. Our mistake. It will be added in the same commit that fixes Asheraf's review.

iRagno · 2017-01-10T00:07:27Z

Prior to send new commit, I have a question. According to kRO database, item 19686 - Costume Santa Doll Headband has an effect of small chance to become in Antonio:

산타인형을 모티브로 장식된 머리띠.
물리, 마법 공격 시 일정확률로 안토니오가 빙의된다.
계열 : 의상장비 방어 : 0
위치 : 상단 무게 : 0
요구 레벨 : 1
장착 : 전직업
http://ro.gnjoy.com/guide/runemidgarts/itemview.asp?itemSeq=3&ID=19686

Second line can be translated to: "Physical, Magical Attack: There is a certain probability to transform in Antonio."

This is a Costume headgear. Does this has an effect?

Asheraf · 2017-01-10T01:21:37Z

@ragn0 the item has the same description on iRO too
Adds a X% chance of transforming into Antonio for X TIME when dealing a physical or magical attack.

iRagno · 2017-01-12T08:14:44Z

Added requested changes, with some more cleaning and modifications that include changes to npctalk messages with a more accurate behavior, but, this will show double npc name until issue #1523 is fixed.

Asheraf · 2017-01-12T08:51:56Z

Font weight FW_NORMAL and size 12 are the default values for the announce command so we could remove them.

iRagno · 2017-01-12T09:23:51Z

Yes, I know, but it is a reminiscence from original script, that is why we keep that.

iRagno · 2017-01-12T22:29:37Z

Also, since we have chinese text thanks to esu1214, we could make traditional chinese translation file to have it with huld. Already pr here:

HerculesWS/CommunityTranslations#1

It may be not a big issue for us, or at least to people who doesn't speak Traditional Chinese, but, it's kinda awesome to see HULD in action with a hard language as Chinese is. That kind of things make us feel proud to have Hercules.

Emistry · 2017-03-03T03:41:39Z