only update zeny achievements and logs for non-zero transactions #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helianthella
added
the
type:bug
|
This change is |
4144
approved these changes
Sep 29, 2018
dastgirp
approved these changes
Oct 1, 2018
dastgirp
reviewed
Oct 1, 2018
| @@ -4506,14 +4506,15 @@ static int pc_payzeny(struct map_session_data *sd, int zeny, enum e_log_pick_typ | |||
| sd->status.zeny -= zeny; | |||
| clif->updatestatus(sd,SP_ZENY); | |||
|
|
|||
| achievement->validate_zeny(sd, -zeny); // Achievements [Smokexyz/Hercules] | |||
| if (zeny > 0) { | |||
There was a problem hiding this comment.
if it's 0, do we even need to process above functions?
particularly:
sd->status.zeny -= zeny;
clif->updatestatus(sd,SP_ZENY);
There was a problem hiding this comment.
someone might want to do Zeny += 0; from a script to force Hercules to send the zeny update packet to the client in case of desync
MishimaHaruna
approved these changes
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
When a player does a zeny transaction,
achievement_validate_zenyis called to see if the transaction triggered the completion of an achievement objective, but this function expectsz < 0 || z > 0, so we should either remove the non-zero assert or only call it when we have a non-zero zeny transaction.This PR fixes http://herc.ws/board/topic/16336--