Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global_configuration.md #2229

Merged
merged 2 commits into from
Oct 21, 2018
Merged

global_configuration.md #2229

merged 2 commits into from
Oct 21, 2018

Conversation

linton-dawson
Copy link
Contributor

@linton-dawson linton-dawson commented Sep 30, 2018 •
edited by Helianthella
Loading

Pull Request Prelude

Changes Proposed

Turned doc/global_configuration.txt into Markdown format.

closes #2216

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@linton-dawson
Copy link
Contributor Author

Why there's > in this line?

I thought it would be a bit "cleaner" if the documentation info was in blockquotes. Should I change it ?

@Helianthella Helianthella changed the base branch from stable to master October 1, 2018 14:17
@Helianthella Helianthella added type:enhancement Issue describes an enhancement or feature that should be implemented component:documentation Affecting the documentation in the doc/ folder labels Oct 1, 2018
@Helianthella Helianthella added this to the Release v2018.10.21 milestone Oct 1, 2018
Helianthella
Helianthella approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@Helianthella Helianthella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎃

@linton-dawson
Copy link
Contributor Author

You're welcome ! 😄

@linton-dawson linton-dawson reopened this Oct 1, 2018
@Helianthella Helianthella mentioned this pull request Oct 2, 2018
Closed
3 tasks
@4144
Copy link
Contributor

4144 commented Oct 6, 2018

please remove merge commits from this pull request

@MishimaHaruna MishimaHaruna merged commit c88c3d4 into HerculesWS:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helianthella Helianthella Helianthella approved these changes

@dastgirp dastgirp dastgirp approved these changes

Assignees
No one assigned
Labels
component:documentation Affecting the documentation in the doc/ folder type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Milestone
Release v2018.10.21
Development

Successfully merging this pull request may close these issues.
6 participants
@linton-dawson @HerculesWSAPI @4144 @dastgirp @Helianthella @MishimaHaruna