Fixes #2215: Turn effect_list.txt into effect_list.md

[akshat157]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Affected Branches:

stable
Issues addressed:
Turn the effect list documentation into markdown

Tracker number: #2215

Known Issues and TODO List

With respect to line 2 of Description of the effect list,
Is the (01f3 <ID> ....... ) supposed to be (0x1f3 <ID> ....... ) ?
If not, then this file is ready to be reviewed.

[HerculesWSAPI]

This change is 

[Helianthella]

thanks for your contribution! 👍

[akshat157]

You're welcome! 🙂

[Emistry]

Could we add those effect constant name into the table as well?
Its odd to always refer two files just to get the right effect and the constant name since we shall encourage user to use constant name rather than effect id.

Number ID	Constant Name	Description
1	EF_NAME	Description

[Helianthella]

@Emistry good idea, let's do it!

what could also be interesting would be to add an added in and a removed in column so we could know which clients can or can't display the effect... but this might be too much work

[Emistry]

I updated it with the constant name column.
Not sure which client work/not working for each effects, so I didnt add the 2 columns you mentioned.

Effect ID from 968+ has no description, I am suck at giving description, maybe someone else could help.

[Helianthella]

the table should be properly aligned:

  ID | Constant Name                  | Description
----:|:-------------------------------|:----------------------------------
  -1 | EF_NONE                        | (none)
   0 | EF_HIT1                        | Regular Hit
   1 | EF_HIT2                        | Bash

And if you want to use Effect ID, the whole first column will have to be enlarged

[Emistry]

Updated.

[MishimaHaruna]

Thank you for your contribution! I'll be merging this now