Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow buildin_getd to work with constants and params #2240

Merged
merged 2 commits into from
Oct 7, 2018
Merged

allow buildin_getd to work with constants and params #2240

merged 2 commits into from
Oct 7, 2018

Conversation

Helianthella
Copy link
Member

Pull Request Prelude

Changes Proposed

Yay! yet another getd-related PR!

Fixes http://herc.ws/board/topic/16346--

@Helianthella
allow buildin_getd to work with constants and params
b71f152 
this is highly discouraged, but it should still work
@Helianthella Helianthella added type:enhancement Issue describes an enhancement or feature that should be implemented component:core:scriptengine Affecting the script engine or the script commands labels Oct 2, 2018
@Helianthella Helianthella added this to the Release v2018.10.21 milestone Oct 2, 2018
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Helianthella Helianthella changed the base branch from stable to master October 2, 2018 01:36
@MishimaHaruna MishimaHaruna merged commit 7120569 into HerculesWS:master Oct 7, 2018
@Helianthella Helianthella deleted the getd-const branch October 7, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
component:core:scriptengine Affecting the script engine or the script commands type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Milestone
Release v2018.10.21
Development

Successfully merging this pull request may close these issues.
4 participants
@Helianthella @HerculesWSAPI @4144 @MishimaHaruna