Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PACKET_ZC_PROPERTY_HOMUN size for old clients #2252

Merged
merged 1 commit into from
Oct 21, 2018
Merged

fix PACKET_ZC_PROPERTY_HOMUN size for old clients #2252

merged 1 commit into from
Oct 21, 2018

Conversation

Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Oct 3, 2018 •
edited
Loading

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

this fixes the size of hp fields in PACKET_ZC_PROPERTY_HOMUN for clients older than 20150513
this bug was introduced in eb54c76

reported at http://herc.ws/board/topic/16349-homunculus-bug-new-update-bug/

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf Asheraf added this to the Release v2018.10.21 milestone Oct 7, 2018
@MishimaHaruna MishimaHaruna merged commit f275d6a into HerculesWS:master Oct 21, 2018
@Asheraf Asheraf deleted the pr4 branch December 19, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2018.10.21
Development

Successfully merging this pull request may close these issues.
4 participants
@Asheraf @HerculesWSAPI @4144 @MishimaHaruna