Added some missing events. #2303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisuka
force-pushed
the
missing-events
branch
2 times, most recently
from
c4e1081
to
f827737
Compare
|
This change is |
Asheraf
requested changes
Oct 25, 2018
kisuka
force-pushed
the
missing-events
branch
4 times, most recently
from
8d5cd28
to
a874d6d
Compare
dastgirp
requested changes
Dec 19, 2018
dastgirp
approved these changes
May 22, 2019
Emistry
reviewed
May 23, 2019
MishimaHaruna
force-pushed
the
missing-events
branch
from
0c34dad
to
3676373
Compare
MishimaHaruna
requested changes
Jan 12, 2020
| mes("... You didn't tell me what I to bring..."); | ||
| next(); | ||
| mes("[Ohholy]"); | ||
| mes("No way! I said ^0000ff 1 Broken Jewel , 3 Holy Water, 1 Red Gemstone, and 1 Yellow Gemstone^000000 clearly.") |
There was a problem hiding this comment.
This doesn't really do what it may seem it's doing
MishimaHaruna
added
the
codereview:needsedits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Affected Branches:
Issues addressed:
Surprisingly I'm not completely done contributing to this project. :p
I took some time this last week or so to go through some of the missing event scripts as well as fix some stuff up.
This Pull Requests does the following:
The dates for the 2004 scripts were confirmed by looking through jAthena files and comparing the quest's contents with event posts from jRO, iRO, and kRO.
I'll be back with more scripts later.
Known Issues and TODO List