Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images #2305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Images #2305

wants to merge 1 commit into from

Conversation

VictoriaLa
Copy link

@VictoriaLa VictoriaLa commented Oct 23, 2018 •
edited
Loading

Image corporate.

Pull Request Prelude

Changes Proposed

Issues addressed:

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf
Copy link
Contributor

Asheraf commented Oct 25, 2018

Im not very sure about this, the white logo does not show with the white github background.

@Helianthella
Copy link
Member

Instead of putting the logo under the header (which looks weird), we could put it directly on the header:

# ![Hercules Logo](https://user-images.githubusercontent.com/3507758/48214059-222a8900-e34d-11e8-871f-9036112c8aa4.png) Hercules

Which renders to:

Hercules Logo Hercules

@dastgirp dastgirp changed the base branch from stable to master June 8, 2019 09:16
@dastgirp dastgirp added the codereview:needsedits Some edits have been requested before the pull request can be accepted label Jun 8, 2019
@VictoriaLa @Emistry
Update README Document
a32ecd6 
- added herc logo.
@Emistry Emistry added component:documentation Affecting the documentation in the doc/ folder and removed codereview:needsedits Some edits have been requested before the pull request can be accepted labels Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sctnightcore sctnightcore sctnightcore approved these changes

@dastgirp dastgirp dastgirp approved these changes

Assignees
No one assigned
Labels
component:documentation Affecting the documentation in the doc/ folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VictoriaLa @HerculesWSAPI @Asheraf @Helianthella @dastgirp @sctnightcore @Emistry