Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend and clean up monster skill DB code #2691

Merged
merged 14 commits into from
May 3, 2020
Merged

Extend and clean up monster skill DB code #2691

merged 14 commits into from
May 3, 2020

Conversation

Kenpachi2k13
Copy link
Member

@Kenpachi2k13 Kenpachi2k13 commented Apr 11, 2020 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • Add missing constants to enable global skills assignment.
  • Harmonize behaviour of cast condition constants.
  • Add some error messages.
  • Add proper defaulting and capping when reading monster skill DBs.
  • Apply code style.
  • Add Windows support for predefined identifier __func__. (Not related to the topic but useful.)

Issues addressed: None.

@Kenpachi2k13 Kenpachi2k13 added type:enhancement Issue describes an enhancement or feature that should be implemented component:core Affecting the Hercules core (i.e. not the game mechanics directly) component:databases Affecting the databases available in the db/ folder status:code-review Awaiting code review component:mechanics:skills Affecting the skills' game mechanics labels Apr 11, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.05.03 milestone Apr 11, 2020
@Kenpachi2k13 Kenpachi2k13 self-assigned this Apr 11, 2020
4144
4144 reviewed Apr 11, 2020
View reviewed changes
src/map/mob.c Show resolved Hide resolved
Asheraf
Asheraf reviewed Apr 11, 2020
View reviewed changes
src/map/mob.c Show resolved Hide resolved
Zarbony added a commit to Zarbony/Hercules that referenced this pull request Apr 12, 2020
@Zarbony
Changed .txt to .md updated some Shemes with the new PR from Kenpachi H…
f033a9c 
…erculesWS#2691
@Kenpachi2k13
Adjust mob_getfriendstatus() to consider characters as friends for su…
c475c1e 
…mmoned monsters like mob_getfriendhprate() does
@Kenpachi2k13
Allow MSC_AFTERSKILL to trigger every skill if ConditionData is set t…
4121c52 
…o 0 (like MSC_SKILLUSED)
@Kenpachi2k13
Add error message for exceeding MAX_MOBSKILL in global skill assignment
2962a44
@Kenpachi2k13
Add error message for unsupported global skill clearing
cec5089
@Kenpachi2k13
Add proper defaulting and capping to mob_skill_db_libconfig_sub_skill()
f8a7e27
@Kenpachi2k13
Remove unnecessary skill target check for ground skills from mob_skil…
a719b01 
…l_db_libconfig_sub_skill()
@Kenpachi2k13
Update mob skill DB file headers (entry structure)
f1f32ff
@Kenpachi2k13
Apply code style to mob_getfriendstatus()
5554403
@Kenpachi2k13
Apply code style to mob_getfriendstatus_sub()
349b2f2
@Kenpachi2k13
Apply code style to mob_skill_use()
9df5181
@Kenpachi2k13
Adjust return value of mob_skill_use() and mobskill_event() according…
452b603 
… to code style
@Kenpachi2k13
Add Windows support for predefined identifier __func__
f42ae14 
__func__ is supported since VS 2015, which is Hercules' oldest supported version.
@Kenpachi2k13
Apply code style to mob_skill_db_libconfig_sub_skill()
e8d6a43
@Kenpachi2k13 Kenpachi2k13 mentioned this pull request Apr 14, 2020
Merged
3 tasks
Kenpachi2k13 added a commit to Zarbony/Hercules that referenced this pull request Apr 14, 2020
@Kenpachi2k13
Update line numbers in links to src/map/mob.c
434c205 
Line numbers in src/map/mob.c get changed in HerculesWS#2691
@MishimaHaruna MishimaHaruna merged commit 24f518f into HerculesWS:master May 3, 2020
@Kenpachi2k13 Kenpachi2k13 deleted the mob_skill_db branch May 4, 2020 14:03
skyleo
skyleo reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@skyleo skyleo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kenpachi2k13 Please address these suggestions in possibly a new pull request.

src/map/mob.c Show resolved Hide resolved
src/map/mob.c Show resolved Hide resolved
src/map/mob.c Show resolved Hide resolved
src/map/mob.c Show resolved Hide resolved
@Kenpachi2k13
Copy link
Member Author

@skyleo Done in #2887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyleo skyleo skyleo left review comments

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

@Helianthella Helianthella Awaiting requested review from Helianthella

@hemagx hemagx Awaiting requested review from hemagx

@Asheraf Asheraf Awaiting requested review from Asheraf

@4144 4144 Awaiting requested review from 4144

Assignees

@Kenpachi2k13 Kenpachi2k13

Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) component:databases Affecting the databases available in the db/ folder component:mechanics:skills Affecting the skills' game mechanics status:code-review Awaiting code review type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Milestone
Release v2020.05.03
Development

Successfully merging this pull request may close these issues.
5 participants
@Kenpachi2k13 @4144 @MishimaHaruna @skyleo @Asheraf