Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Moscovia quests getting stuck in infinite loop #2792

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Fix Moscovia quests getting stuck in infinite loop #2792

merged 2 commits into from
Jul 25, 2020

Conversation

Kenpachi2k13
Copy link
Member

Pull Request Prelude

Changes Proposed

  • Add missing Baehideun4#ship::OnEnable event call.
  • Replace misplaced "next;" with "close;". (Not related to the issue.)

Issues addressed: #2715

@Kenpachi2k13 Kenpachi2k13 added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:scripts Affecting the scripts and NPCs status:code-review Awaiting code review labels Jul 3, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.07.26 milestone Jul 3, 2020
@Kenpachi2k13 Kenpachi2k13 self-assigned this Jul 3, 2020
@Kenpachi2k13 Kenpachi2k13 linked an issue Jul 3, 2020 that may be closed by this pull request
Quest_Moscovia - Loop #2715
Closed
@MishimaHaruna MishimaHaruna merged commit 060133e into HerculesWS:master Jul 25, 2020
@Kenpachi2k13 Kenpachi2k13 deleted the moscovia_quests branch July 25, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

@Emistry Emistry Awaiting requested review from Emistry

@dastgirp dastgirp Awaiting requested review from dastgirp

@Jedzkie Jedzkie Awaiting requested review from Jedzkie

Assignees

@Kenpachi2k13 Kenpachi2k13

Labels
component:scripts Affecting the scripts and NPCs status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Milestone
Release v2020.07.26
Development

Successfully merging this pull request may close these issues.

Quest_Moscovia - Loop
2 participants
@Kenpachi2k13 @MishimaHaruna