fix missing scoreboard for battleground type 2

[AnnieRuru]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Issues addressed

#2848

Changes Proposed

cap the value as 1 or 2 only
if it is 0, it becomes 1(default), and if it is over 2, becomes 2

guild_vs2	mapflag	battleground

tested is 1, because the sscanf return 0 didn't found w4

Affected Branches

• Master

Known Issues and TODO List

blame #2654 ... yeah its @Emistry again

[4144]

may be better cap from 0? cap_value(state, 0, 2)
because with your code if put parameter as 0, it will be used as 1, i think this is wrong.

[AnnieRuru]

	else if (strcmpi(w3, "battleground") == 0) {
		struct map_zone_data *zone;
		if (state != 0) {
			if (w4 != NULL && sscanf(w4, "%d", &state) == 1)
				map->list[m].flag.battleground = (state != 0) ? 1 : 0;
			else
				map->list[m].flag.battleground = 1; // Default value
		} else {
			map->list[m].flag.battleground = 0;
		}

wait, you mean we can use

prontera	mapflag	battleground	0
--same as--
//prontera	mapflag	battleground // not declare it

to turn off the mapflag ?? then what's the point of adding a mapflag line then ?

---

another point I want to make is this line works perfectly fine

setmapflag "prontera", MF_BATTLEGROUND, 2; 

src\map\script.c

static BUILDIN(setmapflag) {...
case MF_BATTLEGROUND: map->list[m].flag.battleground = (val <= 0 || val > 2) ? 1 : val; break;

even this line also said, if set type into 0, default to 1

[4144]

yes i mean this, but i not saw check before. it blocks 0 already. 0 goind in other branch of if.
this can be need if don't want remove map flag but want disable it.

hm, but may be add value validation check? and if it not valid, show error message?
because old and new code silently accept any values...

[AnnieRuru]

I really don't see the point of using value 0
there are already *removemapflag script command that can remove a mapflag

just changing the value 1 into 0 doesn't mean anything, but doing it doesn't cost me my arm or leg, so I'll do it

[AnnieRuru]

just remember after doing this change, now will create inconsistent

prontera	mapflag	battleground	0

which doesn't do anything ...... !!!

while the *setmapflag script command can only set value 1 or 2