Allow override libconfig command @include #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyleo
requested changes
Oct 26, 2020
| @@ -114,7 +114,17 @@ FILE *scanctx_push_include(struct scan_context *ctx, void *buffer, | |||
| strcat(full_file, file); | |||
| } | |||
|
|
|||
| fp = fopen(full_file ? full_file : file, "rt"); | |||
| if(full_file) | |||
| { | |||
There was a problem hiding this comment.
On same line as previous if pls.
There was a problem hiding this comment.
no. this is part of library. and here used non hercules style
i used same style as in lib
Kenpachi2k13
approved these changes
Oct 29, 2020
Override code try to open first conf/import/include/SERVERNAME/FILEPATH file, if it failed fallback to normal FILEPATH path. This feature need for example for override sql_connection.conf without changing any other configs.
MishimaHaruna
approved these changes
Nov 16, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Override code try to open first conf/import/include/SERVERNAME/FILEPATH file,
if it failed fallback to normal FILEPATH path.
This feature need for example for override sql_connection.conf
without changing any other configs.