Make Impositio Manus always overwrites itself #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenpachi2k13
added
type:bug
Kenpachi2k13
requested review from
4144,
MishimaHaruna,
hemagx,
skyleo and
Asheraf
Closed
AnnieRuru
requested changes
Nov 1, 2020
4144
approved these changes
Nov 1, 2020
Kenpachi2k13
force-pushed
the
impositio_manus
branch
from
1b91cb3
to
7b9882e
Compare
AnnieRuru
requested changes
Nov 2, 2020
| if (type != SC_GENTLETOUCH_CHANGE) | ||
| status_change_end(bl, SC_GENTLETOUCH_CHANGE, INVALID_TIMER); | ||
|
|
||
| break; |
There was a problem hiding this comment.
why there are so many empty lines ?
I guess its still editing
There was a problem hiding this comment.
Nope, that's final. Those blank lines improve the readability. (At least in my opinion.)
There was a problem hiding this comment.
I recheck the hercules coding style and ...
it only says leave empty lines for comments ... and each every new function
these line break ... doesn't fall into either of these ...
well if the code doesn't break then I trust you =/
There was a problem hiding this comment.
The code wont break. It's just a clear visual separation between the if-clause and leaving the switch-case.
AnnieRuru
approved these changes
Nov 2, 2020
MishimaHaruna
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Impositio Manus always overwrites itself regardless of which skill level is used.
The skill rebalancing update changed this behaviour, but yet we didn't even start implementing that update.
Issues addressed: #695