Haste Effect ignores some statuses #2928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKeiKun
force-pushed
the
fix-haste_effect
branch
from
ff81da6
to
ac0f906
Compare
MrKeiKun
force-pushed
the
fix-haste_effect
branch
from
ac0f906
to
e0b9717
Compare
MrKeiKun
force-pushed
the
fix-haste_effect
branch
2 times, most recently
from
2966317
to
dbd283d
Compare
MrKeiKun
force-pushed
the
fix-haste_effect
branch
from
dbd283d
to
f9c7c77
Compare
|
Can you explain to me what the previous behavior was? Judging from your commit it seems like it should already work as intended. What was wrong about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This PR should fix guyak item(haste/boost movement speed) where it should ignore certain statuses.
Issues addressed: