Convert some skill packets to structure format #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
requested changes
Feb 16, 2021
Asheraf
force-pushed
the
skillpackets
branch
from
3651c42
to
de87990
Compare
EPuncker
reviewed
Feb 17, 2021
| type = clif_calc_delay(type, div, damage, ddelay); | ||
|
|
||
| #if PACKETVER >= 20131223 | ||
| if (type == BDT_SKILL) type = BDT_MULTIHIT; //bugreport:8263 | ||
| // For some reason, late 2013 and newer clients have | ||
| // a issue that causes players and monsters to endure |
There was a problem hiding this comment.
Suggested change
| // a issue that causes players and monsters to endure | |
| // an issue that causes players and monsters to endure |
MishimaHaruna
requested changes
Mar 8, 2021
MishimaHaruna
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude