Report to console if a missing message is requested #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
requested changes
Mar 1, 2021
If show_msg() requests a message code which is not present in messages.conf, a "??" will be provided silently. This raises a warning so maintainers can debug and fix their messages.conf file.
4144
approved these changes
Mar 1, 2021
MishimaHaruna
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
If show_msg() requests a message code which is not present in messages.conf, a "??" will be provided silently.
This raises a warning so maintainers and fork owners can debug and fix their messages.conf file.
(This should not happen normally).
Issues addressed: None