Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AM_ACIDTERROR not ignoring def on units other than players #3234

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Sep 24, 2023

Pull Request Prelude

Changes Proposed

Due to a coding bug in eathena, AM_ACIDTERROR only ignores defense on those target types defined in battle_config.vit_penalty_target.
This change makes AM_ACIDTERROR ignore defense regardless of this setting and target type.

Issues addressed:
None

@csnv csnv changed the base branch from stable to master September 24, 2023 01:41
Copy link
Contributor

@skyleo skyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MishimaHaruna MishimaHaruna added this to the Release v2023.10 milestone Oct 14, 2023
@MishimaHaruna MishimaHaruna merged commit c6952c1 into HerculesWS:master Oct 14, 2023
96 of 254 checks passed
@csnv csnv deleted the fix/acidterror_defense branch November 1, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants