Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when reloading unit params db #3288

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

guilherme-gm
Copy link
Member

Pull Request Prelude

Changes Proposed

Fixes a memory leak in unit params db when it was reloaded (e.g. through @reloadstatusdb). This was caused because the current implementation was not freeing the existing data before creating a new one.

I have also renamed status->unit_params_destroy to status->unit_params_destroy_entry to make its objective explicit, since I now added status->unit_params_clear_db too.

Thanks skyleo and Haru for the infos and suggestion on how to fix.

Issues addressed:
None

@MishimaHaruna MishimaHaruna merged commit 6cacf72 into HerculesWS:master Apr 30, 2024
346 checks passed
@MishimaHaruna MishimaHaruna added this to the Release v2024.04 milestone Apr 30, 2024
@guilherme-gm guilherme-gm deleted the fix-stats-leak branch May 1, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants