Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement m(atk) / m(def) percent system #3290

Merged
merged 33 commits into from
Apr 30, 2024
Merged

Implement m(atk) / m(def) percent system #3290

merged 33 commits into from
Apr 30, 2024

Commits on Apr 15, 2024

  1. Implement atk/def percent calculation design

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    10c141c View commit details
    Browse the repository at this point in the history

  2. Include atk-percent on client status-window just like on officials 

    Apparently matk-percent isn't displayed on the client-side,
although there is another value in Aegis named extMagicAttPercent that is being
included in it, which is something completely different than matk-percent.
    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    edf49ba View commit details
    Browse the repository at this point in the history

  3. Include def-percent on clientside vit def only like on officials

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    cad69e7 View commit details
    Browse the repository at this point in the history

  4. Send updatestatus to client when atk or def percent change

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9116ae8 View commit details
    Browse the repository at this point in the history

  5. Ensure that we know if enum scb_flag can't be bigger than 32 bit

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b49d223 View commit details
    Browse the repository at this point in the history

  6. Use enum scb_flag type where intended to

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0e3d1e5 View commit details
    Browse the repository at this point in the history

  7. Implement atk_percent into battle->calc_weapon_attack for general cases

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d9b6380 View commit details
    Browse the repository at this point in the history

  8. Implement def_percent into battle->calc_defense similar to official b… 

    …ehavior
    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    df6d8d2 View commit details
    Browse the repository at this point in the history

  9. Implement matk_percent into battle->calc_magic_attack for general cases

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    618e47b View commit details
    Browse the repository at this point in the history

  10. Implement mdef_percent into status->calc_mdef2 similar to official be… 

    …havior
    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9573e8f View commit details
    Browse the repository at this point in the history

  11. Implement proper atk-def-percent handling for Tarot Card of Fate

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6ae0bc8 View commit details
    Browse the repository at this point in the history

  12. Implement proper atk-percent handling for Gospel

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    12af335 View commit details
    Browse the repository at this point in the history

  13. Implement proper atk-def-percent handling for Provoke

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    adc989b View commit details
    Browse the repository at this point in the history

  14. Implement proper atk-def-percent handling for LK_CONCENTRATION

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c2d8dd8 View commit details
    Browse the repository at this point in the history

  15. Implement proper atk-percent handling for Homunculus skill Blood Lust

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    66ae990 View commit details
    Browse the repository at this point in the history

  16. Implement proper atk-def-percent handling for LK_JOINTBEAT

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6707359 View commit details
    Browse the repository at this point in the history

  17. Implement proper atk-def-percent handling for SL_SKE

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e740c3d View commit details
    Browse the repository at this point in the history

  18. Implement proper atk-percent handling for HLIF_FLEET

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9c0138d View commit details
    Browse the repository at this point in the history

  19. Implement proper atk-percent handling for Curse

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8b5a3b8 View commit details
    Browse the repository at this point in the history

  20. Implement proper atk-percent handling for NPC_POWERUP's SC_INCATKRATE

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2b2cd3e View commit details
    Browse the repository at this point in the history

  21. Implement proper atk-percent handling for Divest Weapon

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    68ef746 View commit details
    Browse the repository at this point in the history

  22. Implement proper matk-mdef-percent handling for PF_MINDBREAKER

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6f0c6b9 View commit details
    Browse the repository at this point in the history

  23. Add comment for SC_INCMATKRATE being used by nothing

    @skyleo
    skyleo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bf51a23 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Implement proper def-percent handling for RG_STRIPSHIELD

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    598e1f7 View commit details
    Browse the repository at this point in the history

  2. Implement proper def-percent-handling for GS_FLING

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    36f47db View commit details
    Browse the repository at this point in the history

  3. Implement proper def-percent-handling for Angelus

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    46865af View commit details
    Browse the repository at this point in the history

  4. Implement proper def-percent handling for SC_POISON and SC_DPOISON

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e249e01 View commit details
    Browse the repository at this point in the history

  5. Add comment for SC_STONESKIN in the future

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4d1793b View commit details
    Browse the repository at this point in the history

  6. Add known enum scb_flag to HPMHookGen

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3e93716 View commit details
    Browse the repository at this point in the history

  7. Regenerate hooks

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    63c2f9f View commit details
    Browse the repository at this point in the history

  8. Fix Asura Strike being affected by ATK % bonuses such as Provoke or G… 

    …ospel
    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    159f6c1 View commit details
    Browse the repository at this point in the history

  9. Improve MSVC support for enum scb_flag via typedef e_scb_flag

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    085785b View commit details
    Browse the repository at this point in the history

  10. Regenerate hooks

    @skyleo
    skyleo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    25e2d3c View commit details
    Browse the repository at this point in the history