Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI updates for deprecation warnings #3317

Merged
merged 5 commits into from
Aug 31, 2024
Merged

CI updates for deprecation warnings #3317

merged 5 commits into from
Aug 31, 2024

Conversation

MishimaHaruna
Copy link
Member

@MishimaHaruna MishimaHaruna commented Aug 31, 2024 •
edited
Loading

Pull Request Prelude

Changes Proposed

Some maintenance changes to the GitHub Actions CI scripts:

  • Updated action/checkout to v4 (previous versions required node v16 and caused a deprecation warning)
  • Updated the codeql-action/* actions to v3 (v2 required node v16 and caused a deprecation warning; an additional deprecation warning said that v2 will be retired in dec 2024)
  • Removed the workflows that don't support at least nodejs v20 (Ubuntu 18.04, which is EOL, doesn't). This implies the removal of the gcc-4.8, gcc-5 and gcc-6 builds which are irrelevant for the project (the earliest gcc versions available in the earliest distributions that we officially support at this point are gcc-9 on Debian 11 and gcc-7 on Ubuntu 20.04 LTS.)
  • Updated Homebrew package names for the macOS builds (mysql-connector-c is replaced by mysql-client)
  • Reduced the job timeout from 60 to 30 minutes to make any stuck jobs timeout earlier instead of hogging the runners for too long. Currently, all jobs normally complete in less than 30 minutes. This can be increased again in future if it turns out not to be enough.

Issues addressed: N/A

@MishimaHaruna
Switch to actions/checkout@v4
3118892 
This fixes the following deprecation warning in GitHub Actions:

- 'The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/checkout@v1'

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna
Switch to codeql-action/init@v3, codeql-action/autobuild@v3, codeql-a…
d898cb5 
…ction/analyze@v3

This fixes the following deprecation warnings in GitHub Actions:

- 'The following actions use a deprecated Node.js version and will be forced to run on node20: github/codeql-action/init@v2, github/codeql-action/autobuild@v2, github/codeql-action/analyze@v2'
- 'CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3"

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna
Remove the deprecated packet mysql-connector-c (replaced by mysql-cli…
71eeb07 
…ent) in the macos CI builds

This fixes the following deprecation warning in GitHub Actions:

- 'Formula mysql-connector-c was renamed to mysql-client'

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna
Reduce the GitHub Actions job timeout from 60 to 30 minutes
409dc5f 
The only jobs that take over 30 minutes are usually only the ones that got stuck. This ensures that stuck jobs don't hog the entire CI for too long.

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna added this to the Release v2024.08 milestone Aug 31, 2024
@MishimaHaruna MishimaHaruna marked this pull request as draft August 31, 2024 19:08
@MishimaHaruna
Drop the CI builds that require Ubuntu 18.04, which has been EoL for …
0a32256 
…several months

The nodejs v20 actions require at least Ubuntu 20.04 to run. Downgrading
to nodejs 16 and extending its agony for a few more months until they
become fully unsupported seems pointless to me.

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna marked this pull request as ready for review August 31, 2024 23:22
@skyleo
Copy link
Contributor

skyleo commented Aug 31, 2024

LGTM

@MishimaHaruna MishimaHaruna merged commit 891195a into HerculesWS:master Aug 31, 2024
316 checks passed
@MishimaHaruna MishimaHaruna deleted the ci-updates branch August 31, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyleo skyleo skyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2024.08
Development

Successfully merging this pull request may close these issues.
2 participants
@MishimaHaruna @skyleo