Improved atCommand(iteminfo)

[Venseer]

Pull Request Prelude

• [ x ] I have followed proper Hercules code styling.
• [ x ] I have read and understood the contribution guidelines before making this PR.
• [ x ] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Uses itemlink on iteminfo atcommand.
No longer list slots on iteminfo, itemlink contains slot information.

[dastgirp]

This needs to be PACKETVER specific, as it won't work for old Clients

[Venseer]

Do you happen to have the min packetver? I can work that out.

[Venseer]

This needs to be PACKETVER specific, as it won't work for old Clients

Just checked clif_format_itemlink. It verifies packetver and writes only whats compatible.
Check clif.c line 26044

[MishimaHaruna]

Thank you! Please check the following things before I can merge this

[kyeme]

Not working in 2016-01-06aRagexe client?

[guilherme-gm]

@kyeme may you try making an npc with this?

mesf("Your item is: %s", getitemlink(Apple));

does it render properly or also shows the tag like that?

I think it might be the case that not every client supports those tags in the same places 🫠 I remember testing and checking client for mes, but not for other places.

[dastgirp]

@kyeme may you try making an npc with this?

mesf("Your item is: %s", getitemlink(Apple));

does it render properly or also shows the tag like that?

I think it might be the case that not every client supports those tags in the same places 🫠 I remember testing and checking client for mes, but not for other places.

2020 client doesn't support getitemlink in "mes".
So 2016 might not support it as well

[guilherme-gm]

@kyeme may you try making an npc with this?

mesf("Your item is: %s", getitemlink(Apple));

does it render properly or also shows the tag like that?
I think it might be the case that not every client supports those tags in the same places 🫠 I remember testing and checking client for mes, but not for other places.

2020 client doesn't support getitemlink in "mes". So 2016 might not support it as well

hmm well noted, my 2019-12-24 client "partially" supports it, it doesn't make the text clickable, but it does render the item name.
Maybe dispbottom would be a better test to check whether the tag is broken for the client or it just doesn't support it in message?