Compilation fixes for Xcode 7.3 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the in-tree copy of Sparkle to v1.13.1 for the security vulnerabilities mentioned in https://vulnsec.com/2016/osx-apps-vulnerabilities/. Change SUFeedURL to use https:// to protect against MITM of AppCast feed (fixes #254).
…ting deprecated methods
…s now builds and runs!
Update Sparkle to v1.13.1 and change SUFeedUrl to use https://
Fix truncation at 1024 bytes of response, usually impacting the abili…
Add support for high quality 192k mp3 for Pandora One
(playing, paused, stopped)
| @@ -652,6 +652,11 @@ | |||
| attributes = { | |||
| BuildIndependentTargetsInParallel = YES; | |||
| LastUpgradeCheck = 0730; | |||
| TargetAttributes = { | |||
| 8D1107260486CEB800E47090 = { | |||
| DevelopmentTeam = 8END7325T3; | |||
There was a problem hiding this comment.
This is your personal key? We should likely not commit this into the general repository.
Nevermind, I see you removed this in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hermes seemed to need a bit of tweaking to get compiling on Xcode 7.3, including updating methods that used deprecated methods and fixing up the project file. App has undergone preliminary testing. I would be interested in taking over maintenance of the project.