Hero causes excessive warnings in Bitrise

[danielsaidi]

What did you do?

Build an app that uses Hero on Bitrise

What did you expect to happen?

Bitrise should builds with no warnings, or at least very few, so that we can focus on important warnings instead of unnecessary ones.

What happened instead?

Bitrise explodes in warning regarding code quality within Hero.

General Information

• Hero Version: 1.4.0

• iOS Version(s): 13

• Swift Version: 5.1

• Devices/Simulators: -

• Reproducible in Examples? (Yes/No): Yes

When you build in Bitrise, the logs fill up with warnings about code issues in Hero, that are easily solved, for instance:

 /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:30:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let easeInOut = CAMediaTimingFunction(name: CAMediaTimingFunctionName.easeInEaseOut)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:33:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let standard = CAMediaTimingFunction(controlPoints: 0.4, 0.0, 0.2, 1.0)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:34:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let deceleration = CAMediaTimingFunction(controlPoints: 0.0, 0.0, 0.2, 1)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:35:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let acceleration = CAMediaTimingFunction(controlPoints: 0.4, 0.0, 1, 1)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:36:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let sharp = CAMediaTimingFunction(controlPoints: 0.4, 0.0, 0.6, 1)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CAMediaTimingFunction+Hero.swift:39:3: 'public' modifier is redundant for static property declared in a public extension
[21:04:53]: ▸   public static let easeOutBack = CAMediaTimingFunction(controlPoints: 0.175, 0.885, 0.32, 1.275)
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CG+Hero.swift:43:3: 'internal' modifier is redundant for property declared in an internal extension
[21:04:53]: ▸   internal var center: CGPoint {
[21:04:53]: ▸   ^~~~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CG+Hero.swift:46:3: 'internal' modifier is redundant for property declared in an internal extension
[21:04:53]: ▸   internal var point: CGPoint {
[21:04:53]: ▸   ^~~~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CG+Hero.swift:58:3: 'internal' modifier is redundant for property declared in an internal extension
[21:04:53]: ▸   internal var center: CGPoint {
[21:04:53]: ▸   ^~~~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/CG+Hero.swift:61:3: 'internal' modifier is redundant for property declared in an internal extension
[21:04:53]: ▸   internal var bounds: CGRect {
[21:04:53]: ▸   ^~~~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/UIView+Hero.swift:52:4: 'public' modifier is redundant for property declared in a public extension
[21:04:53]: ▸    public var id: String? {
[21:04:53]: ▸    ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/UIView+Hero.swift:61:3: 'public' modifier is redundant for property declared in a public extension
[21:04:53]: ▸   public var isEnabled: Bool {
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/UIView+Hero.swift:70:3: 'public' modifier is redundant for property declared in a public extension
[21:04:53]: ▸   public var isEnabledForSubviews: Bool {
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/UIView+Hero.swift:78:3: 'public' modifier is redundant for property declared in a public extension
[21:04:53]: ▸   public var modifiers: [HeroModifier]? {
[21:04:53]: ▸   ^~~~~~~
[21:04:53]: ▸ ⚠️  /Users/vagrant/Library/Developer/Xcode/DerivedData/BookBeat-fxafdpcsmubmsucbijoshrzlgggw/SourcePackages/checkouts/Hero/Sources/Extensions/UIView+Hero.swift:86:3: 'public' modifier is redundant for property declared in a public extension
[21:04:53]: ▸   public var modifierString: String? {

[danielsaidi]

#616 solves this problem.

[JoeMatt]

Closed. Pr merged.