Remove access modifier warnings #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeMatt
reviewed
Oct 7, 2019
| extension CGPoint { | ||
| internal func translate(_ dx: CGFloat, dy: CGFloat) -> CGPoint { | ||
|
|
||
| internal extension CGPoint { |
There was a problem hiding this comment.
Technically this internal marking isn't required either,
If you extend a public or internal type, any new type members you add have a default access level of internal.
But since XCode keeps flipping how it feels about visibility I think it's not a bad idea to e explicit here.
JoeMatt
approved these changes
Oct 7, 2019
iDevid
approved these changes
Oct 7, 2019
JoeMatt
pushed a commit
that referenced
this pull request
Oct 21, 2019
JoeMatt
pushed a commit
that referenced
this pull request
Oct 29, 2019
JoeMatt
added a commit
that referenced
this pull request
Oct 29, 2019
- Fix iOS demo app failing and style on iOS 13 - Fix lint warnings and build errors in demo app - Add extra metadata to podspec - Deprecated messages to renamed - Add Joe Mattiello into Podspec authors for publishing - Fix pod lib lint failures - Update Podspec imports to match source imports - Use more minimal import - Remove Swift files from framework bundle products - Remove access modifier warnings (#616) - GitIgnore xcode log files - Docs - Run jazzy against new spec - Docs - Update jazzy config - Bump version to 1.5.0 - Set theme jekyll-theme-midnight - Use custom snapshot for views that implements HeroCustomSnapshotView (#541) - Keep using default navigation animation direction with RTL languages (#520) - Hidden subviews not taken in account in optimized snapshot type (#521) - Update Collection 2.0 (#553) Signed-off-by: Joe Mattiello <git@joemattiello.com> # gpg: Signature made Mon Oct 28 21:28:30 2019 EDT # gpg: using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365 # gpg: Good signature from "Joseph Mattiello <mail@joemattiello.com>" [ultimate] # gpg: aka "Joseph Mattiello <git@joemattiello.com>" [ultimate] # gpg: aka "Joseph Mattiello <joe@provenance-emu.com>" [ultimate] # gpg: aka "Joseph Mattiello <jmattiello@newscorp.com>" [ultimate] # gpg: aka "Joseph Mattiello (Public Git repo commit identity) <git@joemattiello.com>" [ultimate] # Conflicts: # Sources/Extensions/UIView+Hero.swift # Sources/Extensions/UIViewController+Hero.swift
dylanmoo
pushed a commit
to RayaTheApp/Hero
that referenced
this pull request
Sep 1, 2020
…om-master * upstream/master: JazzyDocs fix various URLs Update Hero.podspec - fix screenshot url strings Bump target versions to 1.5.0 Fix iOS demo app failing and style on iOS 13 Fix lint warnings and build errors in demo app Add extra metadata to podspec Deprecated messages to renamed Add Joe Mattiello into Podspec authors for publishing Fix pod lib lint failures Update Podspec imports to match source imports Use more minimal import Remove Swift files from framework bundle products Remove access modifier warnings (HeroTransitions#616) GitIgnore xcode log files Docs - Run jazzy against new spec Docs - Update jazzy config Bump version to 1.5.0 Set theme jekyll-theme-midnight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hero causes excessive and unnecessary warning loggings for redundant access modifier information, for instance when building apps that use it on Bitrise. It also warns about the version number in two deprecations.
Removing access modifiers that match their enclosing extension makes these warnings go away. I also removed the version number in the deprecations.
The PR has no functional changes.