Keep using default navigation animation direction with RTL languages #520

ManueGE · 2018-08-28T20:49:27Z

If the user is using an RTL (right to left) language, the navigation controller is expected to use the inverse transition directions by default: .right for pushing and .left for popping.

Currently, it is not working, and the navigation controllers behave as it does in LTR languages.

This commit fixes this issue.

SD10 · 2018-08-29T20:37:10Z

Hey @ManueGE,

Thanks for this PR 👍 I'll have to dig a bit deeper regarding this one. My first thought is -- are you able to easily achieve this effect at the client level?

I don't really like the idea of changing the behavior of .left and .right based on the user's language. I think these directions should be taken quite literally -- as they are with the Apple APIs.

I think it's better to use the terms .leading and .trailing for directions that change based on a users language

ManueGE · 2018-08-30T05:59:28Z

I'm actually not changing the behavior of .left or .right, I am just choosing one of them for the .auto animation based on the user language.

Adding a .leading and .trailing direction maybe is a little more semantic, so we can go this way too.

I can fix it at client level easily, but anyway I am using my own fork of Hero in my app because it has another change I needed (#513), so it is not blocking me at all.

Thanks.

ManueGE · 2018-08-30T06:17:46Z

I added .leading and .trailing, but instead of adding a new case in the enum I made them computed static vars, so they can be used as cases.

Also added .leadingToTrailing and .trailingToLeading in CascadeDirection.

What do you think?

SD10 · 2018-08-30T14:06:55Z

@ManueGE This seems both reasonable and flexible to me, thanks 👍 Going to see if anyone else has some input on this issue so that I'm not dictating a decision

ManueGE · 2018-12-18T14:38:19Z

Any new with this PR?

SD10 · 2018-12-18T15:43:15Z

Sources/Preprocessors/DefaultAnimationPreprocessor.swift

@@ -249,9 +259,9 @@ class DefaultAnimationPreprocessor: BasePreprocessor {
      if animators.contains(where: { $0.canAnimate(view: toView, appearing: true) || $0.canAnimate(view: fromView, appearing: false) }) {
        defaultAnimation = .none
      } else if inNavigationController {
-        defaultAnimation = presenting ? .push(direction:.left) : .pull(direction:.right)
+        defaultAnimation = presenting ? .push(direction:.leading) : .pull(direction:.trailing)


@ManueGE The only thing that concerns me is now we're changing the behavior of this animation. I agree that it's nice to change things based on the userInterfaceLayoutDirection -- but a Hero user could be relying on this not being changed

You are totally right, I understand that some users could be relying on this even if maybe it's not the "right" behavior. I saw it as a bug fix, but I understand your point.

Can we make this configurable so that users can opt-in to the old behavior?

Let me think about it a little bit. Will try to figure out something tomorrow

I pushed a change. I kept the "left to right" default behavior, but "user interface" and "right to left" behaviors can be set using the defaultTransitionDirectionStrategy property of HeroTransition.

Thanks @ManueGE. I skimmed this earlier this week. This looks totally reasonable 👍 Will review tomorrow and hopefully merge + release!

SD10 · 2018-12-18T15:43:30Z

Sources/Preprocessors/DefaultAnimationPreprocessor.swift

      } else if inTabBarController {
-        defaultAnimation = presenting ? .slide(direction:.left) : .slide(direction:.right)
+        defaultAnimation = presenting ? .push(direction:.leading) : .pull(direction:.trailing)


Why did we change from .slide to .push here?

oops, you are right. My bad, will fix it.

SD10 · 2018-12-18T15:45:01Z

@ManueGE Yeah, I was able to review this a bit and left you some comments above. Sorry I've been swamped at work for months now 😞 If you need me to look at something the best way is to ping me on GitHub or DM me on Twitter 😓

Also added `.leadingToTrailing` and `trailingToLeading` Cascade direction

right to left and user interface behaviours can be set using the `defaultTransitionDirectionStrategy` property.

SD10

⛵️

- Fix iOS demo app failing and style on iOS 13 - Fix lint warnings and build errors in demo app - Add extra metadata to podspec - Deprecated messages to renamed - Add Joe Mattiello into Podspec authors for publishing - Fix pod lib lint failures - Update Podspec imports to match source imports - Use more minimal import - Remove Swift files from framework bundle products - Remove access modifier warnings (#616) - GitIgnore xcode log files - Docs - Run jazzy against new spec - Docs - Update jazzy config - Bump version to 1.5.0 - Set theme jekyll-theme-midnight - Use custom snapshot for views that implements HeroCustomSnapshotView (#541) - Keep using default navigation animation direction with RTL languages (#520) - Hidden subviews not taken in account in optimized snapshot type (#521) - Update Collection 2.0 (#553) Signed-off-by: Joe Mattiello <git@joemattiello.com> # gpg: Signature made Mon Oct 28 21:28:30 2019 EDT # gpg: using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365 # gpg: Good signature from "Joseph Mattiello <mail@joemattiello.com>" [ultimate] # gpg: aka "Joseph Mattiello <git@joemattiello.com>" [ultimate] # gpg: aka "Joseph Mattiello <joe@provenance-emu.com>" [ultimate] # gpg: aka "Joseph Mattiello <jmattiello@newscorp.com>" [ultimate] # gpg: aka "Joseph Mattiello (Public Git repo commit identity) <git@joemattiello.com>" [ultimate] # Conflicts: # Sources/Extensions/UIView+Hero.swift # Sources/Extensions/UIViewController+Hero.swift

SD10 requested a review from lkzhao August 30, 2018 14:06

cs4alhaider approved these changes Sep 7, 2018

View reviewed changes

cs4alhaider approved these changes Sep 8, 2018

View reviewed changes

SD10 reviewed Dec 18, 2018

View reviewed changes

ManueGE force-pushed the rtl branch from ea114d3 to ed8b969 Compare December 18, 2018 21:49

ManueGE added 2 commits December 18, 2018 22:53

Keep using default navigation animation direction with RTL languages

602a94e

Add .leading and .trailing animation direction

8aeca95

Also added `.leadingToTrailing` and `trailingToLeading` Cascade direction

ManueGE force-pushed the rtl branch from ed8b969 to 8aeca95 Compare December 18, 2018 21:53

Manuel G-Estañ and others added 5 commits December 18, 2018 23:04

Fix default animation for controllers in tab bar controller

8d40cce

Keep left to right as default behaviour for default transitions

ab6d6a6

right to left and user interface behaviours can be set using the `defaultTransitionDirectionStrategy` property.

Update CHANGELOG.md

4497bd7

Update CHANGELOG and move to correct section

aeb84ac

Merge branch 'master' into rtl

0f64af9

SD10 approved these changes Dec 27, 2018

View reviewed changes

SD10 merged commit faf8475 into HeroTransitions:master Dec 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep using default navigation animation direction with RTL languages #520

Keep using default navigation animation direction with RTL languages #520

ManueGE commented Aug 28, 2018

SD10 commented Aug 29, 2018

ManueGE commented Aug 30, 2018 •

edited

Loading

ManueGE commented Aug 30, 2018

SD10 commented Aug 30, 2018

ManueGE commented Dec 18, 2018

SD10 Dec 18, 2018

ManueGE Dec 18, 2018

SD10 Dec 18, 2018

ManueGE Dec 18, 2018

ManueGE Dec 18, 2018 •

edited

Loading

SD10 Dec 22, 2018

SD10 Dec 18, 2018

ManueGE Dec 18, 2018

ManueGE Dec 18, 2018

SD10 commented Dec 18, 2018

SD10 left a comment

Keep using default navigation animation direction with RTL languages #520

Keep using default navigation animation direction with RTL languages #520

Conversation

ManueGE commented Aug 28, 2018

SD10 commented Aug 29, 2018

ManueGE commented Aug 30, 2018 • edited Loading

ManueGE commented Aug 30, 2018

SD10 commented Aug 30, 2018

ManueGE commented Dec 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManueGE Dec 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SD10 commented Dec 18, 2018

SD10 left a comment

Choose a reason for hiding this comment

ManueGE commented Aug 30, 2018 •

edited

Loading

ManueGE Dec 18, 2018 •

edited

Loading