Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM integration causes compiler Issues, preventing the project from building #704

Closed
joshwoods opened this issue Feb 20, 2021 · 3 comments · Fixed by #706
Closed

SPM integration causes compiler Issues, preventing the project from building #704

joshwoods opened this issue Feb 20, 2021 · 3 comments · Fixed by #706
Assignees
Milestone

Comments

@joshwoods
Copy link

What did you do?

Installed Hero via SPM and then was not able to actually build the project. See screenshot below.

What did you expect to happen?

The project should be able to build, however, there are multiple issues throughout the project when integrating via SPM.

What happened instead?

Screen Shot 2021-02-20 at 4 23 36 PM

General Information

  • Hero Version:
    1.6.0

  • iOS Version(s):
    iOS 14.4

  • Devices/Simulators:
    iPhone 12 Pro Max

  • Reproducible in Examples? (Yes/No):
    Yes

Demo Project

test.zip

@JoeMatt
Copy link
Collaborator

JoeMatt commented Feb 22, 2021

SPM is strange with imports. Probably need to add missing import Foundation, import CoreGraphics.

I had added a bunch and it was building with SPM before my merge. I'll check out your sample project, thanks.

JoeMatt added a commit that referenced this issue Feb 22, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
@JoeMatt JoeMatt mentioned this issue Feb 22, 2021
@JoeMatt JoeMatt linked a pull request Feb 22, 2021 that will close this issue
@JoeMatt JoeMatt self-assigned this Feb 22, 2021
@JoeMatt JoeMatt added this to the 1.7.0 milestone Feb 22, 2021
@JoeMatt
Copy link
Collaborator

JoeMatt commented Feb 22, 2021

@joshwoods Can you point your SPM config to branch feature/704_SPM_Fixes and see if it's fixed please.

@JoeMatt JoeMatt linked a pull request Feb 22, 2021 that will close this issue
@JoeMatt JoeMatt removed a link to a pull request Feb 22, 2021
@z3bi
Copy link

z3bi commented Feb 27, 2021

I was having the same issue but was able to build with SPM using feature/704_SPM_Fixes

JoeMatt added a commit that referenced this issue Mar 2, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants