Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash -- HeroViewPropertyViewContext.swift line 56 #735

Closed
patthehuman opened this issue May 2, 2022 · 2 comments · Fixed by #736
Closed

Crash -- HeroViewPropertyViewContext.swift line 56 #735

patthehuman opened this issue May 2, 2022 · 2 comments · Fixed by #736
Assignees

Comments

@patthehuman
Copy link

partial apply for closure #2 in HeroViewPropertyViewContext.resume(timePassed:reverse:)

Crashed: com.apple.main-thread 0 Hero 0x58598 partial apply for closure #2 in HeroViewPropertyViewContext.resume(timePassed:reverse:) + 56 (HeroViewPropertyViewContext.swift:56) 1 Hero 0x3b4a8 thunk for @escaping @callee_guaranteed () -> () + 28 (<compiler-generated>:28) 2 libdispatch.dylib 0x1e68 _dispatch_call_block_and_release + 32 3 libdispatch.dylib 0x3a2c _dispatch_client_callout + 20 4 libdispatch.dylib 0x11f48 _dispatch_main_queue_drain + 928 5 libdispatch.dylib 0x11b98 _dispatch_main_queue_callback_4CF + 44 6 CoreFoundation 0x522f0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16 7 CoreFoundation 0xc1f4 __CFRunLoopRun + 2532 8 CoreFoundation 0x1f6b8 CFRunLoopRunSpecific + 600 9 GraphicsServices 0x1374 GSEventRunModal + 164 10 UIKitCore 0x513e88 -[UIApplication _run] + 1100 11 UIKitCore 0x2955ec UIApplicationMain + 364 12 Mood App 0x5294 main + 25 (AppDelegate.swift:25) 13 ??? 0x1038e9ce4 (Missing)

Appears line 52 needs some optional question marks.

@JoeMatt
Copy link
Collaborator

JoeMatt commented May 5, 2022

Maybe this is a divide by zero,

      viewPropertyAnimator.fractionComplete = CGFloat(1.0 - timePassed / duration)

I'll update this function in a PR you can test.

@JoeMatt JoeMatt self-assigned this May 5, 2022
JoeMatt added a commit that referenced this issue May 5, 2022
Signed-off-by: Joseph Mattello <mail@joemattiello.com>
@JoeMatt JoeMatt linked a pull request May 5, 2022 that will close this issue
@JoeMatt
Copy link
Collaborator

JoeMatt commented May 5, 2022

Created #736

JoeMatt added a commit that referenced this issue May 6, 2022
make loop improvements

Signed-off-by: Joseph Mattello <mail@joemattiello.com>
JoeMatt added a commit that referenced this issue May 6, 2022
…ertyViewContext_Crash

Fixes #735 check 0 divide, use TimeInt.zero over 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants