[Release] Hero 1.4.0 with Swift 4.2 support #534

SD10 · 2018-09-16T02:44:44Z

Summary

Adds support for Swift 4.2
The example target for iOS does not compile because CollectionKit needs a Swift 4.2 update still

TODO ⏰

N/A

SD10 · 2018-09-16T02:47:09Z

cc @freak4pc @alexanderkhitev @andreipt @rennarda

freak4pc

Builds with no issues! Just a few minor notes :)

freak4pc · 2018-09-17T08:12:00Z

Sources/Debug Plugin/HeroDebugView.swift

@@ -69,18 +69,18 @@ class HeroDebugView: UIView {
    addSubview(backgroundView)

    doneButton = UIButton(type: .system)
-    doneButton.setTitle("Done", for: .normal)
+    doneButton.setTitle("Done", for: UIControl.State.normal)


You can just do .normal, no need to be this explicit :)

freak4pc · 2018-09-17T08:12:06Z

Sources/Debug Plugin/HeroDebugView.swift

    doneButton.addTarget(self, action: #selector(onDone), for: .touchUpInside)
    backgroundView.addSubview(doneButton)

    perspectiveButton = UIButton(type: .system)
-    perspectiveButton.setTitle("3D View", for: .normal)
+    perspectiveButton.setTitle("3D View", for: UIControl.State.normal)


freak4pc · 2018-09-17T08:12:11Z

Sources/Debug Plugin/HeroDebugView.swift

    perspectiveButton.addTarget(self, action: #selector(onPerspective), for: .touchUpInside)
    backgroundView.addSubview(perspectiveButton)

    if showCurveButton {
      arcCurveButton = UIButton(type: .system)
-      arcCurveButton!.setTitle("Show Arcs", for: .normal)
+      arcCurveButton!.setTitle("Show Arcs", for: UIControl.State.normal)


freak4pc · 2018-09-17T08:13:17Z

Sources/Debug Plugin/HeroDebugView.swift

@@ -162,7 +162,6 @@ class HeroDebugView: UIView {
      startLocation = pinchGR.location(in: nil)
      startTranslation = translation
      startScale = scale
-      fallthrough


Why did you remove fallthrough here? I think this needs to fall to the case below

freak4pc · 2018-09-17T08:15:10Z

Sources/Transition/HeroProgressRunner.swift

@@ -61,12 +61,12 @@ class HeroProgressRunner {
    self.isReversed = reverse
    self.duration = totalTime
    displayLink = CADisplayLink(target: self, selector: #selector(displayUpdate(_:)))
-    displayLink!.add(to: RunLoop.main, forMode: RunLoopMode(rawValue: RunLoopMode.commonModes.rawValue))
+    displayLink!.add(to: RunLoop.main, forMode: RunLoop.Mode(rawValue: RunLoop.Mode.common.rawValue))


This can simply be

displayLink!.add(to: .main, forMode: .common)

freak4pc · 2018-09-17T08:15:15Z

Sources/Transition/HeroProgressRunner.swift

  }

  func stop() {
    displayLink?.isPaused = true
-    displayLink?.remove(from: RunLoop.main, forMode: RunLoopMode(rawValue: RunLoopMode.commonModes.rawValue))
+    displayLink?.remove(from: RunLoop.main, forMode: RunLoop.Mode(rawValue: RunLoop.Mode.common.rawValue))


freak4pc · 2018-09-17T08:16:05Z

By the way just realized one more issue here - won't you be breaking support for 4.0 this way? Maybe we should add conditional build statements?

SD10 · 2018-09-17T14:42:09Z

Yeah, @freak4pc conditionals isn't a bad improvement 👍 Given that this library will move slow I'm almost tempted to make 1.3.1 the last Swift 4.0 release but I'll see what I can do

freak4pc · 2018-09-17T19:08:34Z

Even so, migrations to Swift 4.2 will take some time, so it's great supporting the last 2 at least.

SD10 · 2018-09-18T17:22:34Z

Even so, migrations to Swift 4.2 will take some time, so it's great supporting the last 2 at least.

I agree 😢 We're still on Swift 4.0 for our app

But it will delay the release on my end. I guess people can use this branch until I can make the backwards compatability changes

skydivedan · 2018-09-19T02:50:20Z

Is backward compatibility a problem, though?

Version 1.3.x of Hero could be for Swift 4.0, 4.1 users.
Version 1.4.x could be for Swift 4.2 users.

Also, you could set s.swift_version = 4.2 in the Podspec file, as an extra hint for Cocoapods.

If there's a critical change that you think is needed for Swift 4 and Swift 4.2, you could rev 2 separate pods. Probably not ideal I guess, though. Just my $0.02 from an early adopter of Swift 4.2

SD10 · 2018-09-19T05:59:23Z

@skydivedan

Is backward compatibility a problem, though?

I'm not really sure how much of an issue backward compatibility is and how long we would want to support both versions if we did.

I'm personally fine using Hero 1.3.1 and I can't think of any major upcoming Hero releases that would take place before most people have migrated to Swift 4.2. Unless there are strong objections I'll probably just end up pushing this

If there's a critical change that you think is needed for Swift 4 and Swift 4.2, you could rev 2 separate pods. Probably not ideal I guess, though. Just my $0.02 from an early adopter of Swift 4.2

Yeah, probably not ideal 😅 But thanks for the input 👍

CEBATOR · 2018-10-02T13:13:46Z

@SD10 just FYI https://github.com/SoySauceLab/CollectionKit/releases/tag/2.2.0

alexanderkhitev · 2018-10-10T18:48:40Z

@SD10 any news?

SD10 · 2018-10-14T23:12:10Z

Sorry for the delay everyone, I had finally burned out 😓 I feel like I'm slowly recovering but that was rough for me.

I added backward compatibility for previous Swift versions and will release this now. Feel free to open an issue if I botched anything in the environment

metabren · 2018-10-14T23:15:52Z

No problem at all @SD10 — never a nice thing to go through. Thank you for this, and all the best for your recovery. Hope it's a speedy one!

freak4pc · 2018-10-15T04:19:02Z

Hey @SD10,
Please take more time - I know how hard this can be very up close but the community is here to support you. Feel free to at-me in every PR on any organization you need help with.

Take care of yourself, the rest is meaningless ❤️

rennarda and others added 7 commits September 15, 2018 21:39

Updates to swift 4.2. Fixes many linting warnings

fd6d262

Tides up unnecessary code added by automatic conversion

d27e3cb

More tidy up.

721b6e5

Update to Swift 4.2

eb2ff6c

Update TvOSExamples for 4.2

52bd6b5

Update podspec for 1.4.0

20bb5c7

Update CHANGELOG

8ff9e84

SD10 self-assigned this Sep 16, 2018

SD10 requested a review from lkzhao September 16, 2018 02:44

Update CHANGELOG.md

85be93f

SD10 mentioned this pull request Sep 16, 2018

Updates to swift 4.2. Fixes many linting warnings #490

Closed

freak4pc suggested changes Sep 17, 2018

View reviewed changes

SD10 mentioned this pull request Sep 19, 2018

Xcode 10 and Swift 4.2 #536

Closed

evertoncunha mentioned this pull request Sep 28, 2018

Support latest Xcode 10 / Swift 4.2 needed #544

Closed

SD10 added 4 commits October 14, 2018 18:04

Add backwards compatability for previous veSwift rsions

954caf6

Make examples backwards compatible

0655938

Update pods and make example compile

37b59b3

Fix code review comments

0e54bee

SD10 merged commit 6a08cc1 into master Oct 14, 2018

SD10 deleted the swift-4.2 branch October 14, 2018 23:12

JoeMatt mentioned this pull request Oct 7, 2019

[Release] 1.5.0 #620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Hero 1.4.0 with Swift 4.2 support #534

[Release] Hero 1.4.0 with Swift 4.2 support #534

SD10 commented Sep 16, 2018

SD10 commented Sep 16, 2018 •

edited

Loading

freak4pc left a comment

freak4pc Sep 17, 2018

freak4pc Sep 17, 2018

freak4pc Sep 17, 2018

freak4pc Sep 17, 2018

freak4pc Sep 17, 2018

freak4pc Sep 17, 2018

freak4pc commented Sep 17, 2018

SD10 commented Sep 17, 2018

freak4pc commented Sep 17, 2018

SD10 commented Sep 18, 2018 •

edited

Loading

skydivedan commented Sep 19, 2018

SD10 commented Sep 19, 2018

CEBATOR commented Oct 2, 2018

alexanderkhitev commented Oct 10, 2018

SD10 commented Oct 14, 2018

metabren commented Oct 14, 2018

freak4pc commented Oct 15, 2018 •

edited

Loading

[Release] Hero 1.4.0 with Swift 4.2 support #534

[Release] Hero 1.4.0 with Swift 4.2 support #534

Conversation

SD10 commented Sep 16, 2018

Summary

Related

TODO ⏰

SD10 commented Sep 16, 2018 • edited Loading

freak4pc left a comment

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc Sep 17, 2018

Choose a reason for hiding this comment

freak4pc commented Sep 17, 2018

SD10 commented Sep 17, 2018

freak4pc commented Sep 17, 2018

SD10 commented Sep 18, 2018 • edited Loading

skydivedan commented Sep 19, 2018

SD10 commented Sep 19, 2018

CEBATOR commented Oct 2, 2018

alexanderkhitev commented Oct 10, 2018

SD10 commented Oct 14, 2018

metabren commented Oct 14, 2018

freak4pc commented Oct 15, 2018 • edited Loading

SD10 commented Sep 16, 2018 •

edited

Loading

SD10 commented Sep 18, 2018 •

edited

Loading

freak4pc commented Oct 15, 2018 •

edited

Loading