-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress is not showing in Window Icon #3478
Progress is not showing in Window Icon #3478
Comments
This is a limitation of Electron, we use the setProgressBar method that only works on Unity desktop on linux: https://www.electronjs.org/docs/latest/api/browser-window#winsetprogressbarprogress-options
While I guess we could try to find other ways of do that without using Electron's features, I think it's better to request this in Electron's repo so they fix that there to improve the compatibility instead. |
The Electron documentation is a bit misleading. The standard was originally made for Unity, but is also supported n other Desktops such as KDE nowadays. KDE is providing exact the same API, so everything working on the (no longer existing) Unity also works on KDE. I can take a look at Electron itself, but I'm not a Electron developer. |
Electron uses
|
I have now installed libunity from the AUR. It's now working. Maybe you could add libunity to the dependencies.
It does exactly that.
You can ignore that warning. This Interface was created around 10 years ago. It had never changed. There are a lot of programs who call this API directly. Unity no longe exists and this Interface is also supported by other Desktops too, so it will never change. Maybe we get some Day a more official Way as part of the xdg-desktop-portals, but the current Interface will stay. I will create a Issue at Electron to emit the DBus Signal directly. libunity could also be included in The Flatpak, but the Flatpak has another problem: The Interface needs the desktop filename to work, but in the Flatpak the desktop file is Edit: |
…is shouldm be set by gamescope and as Heroic forces it to KDE it will mess up their logs. This is something that needs fixing on the Heroic side Heroic-Games-Launcher/HeroicGamesLauncher#3478
Describe the bug
The latest update added the following:
This is not working on my System (Manjaro KDE).
Add logs
Steps to reproduce
Just download a Game
Expected behavior
The download Progress in shown in the Window Icon
Screenshots
No response
Heroic Version
Latest Stable
System Information
Additional information
If I run
to call the API directly, the Progress is correctly shown in the Icon:
So this is definitely supported in KDE and the Issue is on the side of Heroic.
The text was updated successfully, but these errors were encountered: