Check for Updates On Startup does not toggle off

[redromnon]

IMPORTANT! Do not erase this template!

Is this a game issue? If YES please use our Discord to get help.

Open here only issues with Heroic like: Heroic doesn't open, some button is out of place, Heroic closes unexpectedly, installs got interrupted, etc.

Try to get help on our Wiki first: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Troubleshooting

Describe the bug
The checkbox Check for Updates on Startup, under General (Global) Settings, always toggles itself on despite turning it off. When I reopen the app or move to another tab/window and come back to the General Settings window, the checkbox is turned on automatically. I believe the toggle's state doesn't get saved and thus leads to this issue.

Add Logs
None

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings
2. Click General
3. Under Global Settings
4. Uncheck the Check for Updates on Startup checkbox

Expected behavior
The checkbox should be always unchecked when done so.

Screenshots

Desktop (please complete the following information):

• OS: Pop_OS 20.04
• Heroic Version - 2.1.1 Rayleigh

Additional context
None

[Nocccer]

Can reproduce it. Will try to fix it.

[flavioislima]

Can reproduce it. Will try to fix it.

I believe the issue is on this line:

HeroicGamesLauncher/src/screens/Settings/index.tsx

Line 94 in 5d72a38

} = useToggle(false)

Because this settings' default is true, but on this line, it starts as false. So there is some conflict.
changing here to true should fix the issue.

[Nocccer]

@flavioislima already fixed it for ~2h