Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Fix option check for update on startup #980

Merged
merged 10 commits into from
Feb 23, 2022
Merged

[General] Fix option check for update on startup #980

merged 10 commits into from
Feb 23, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Feb 17, 2022 •
edited
Loading

#978

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 17, 2022
@Nocccer Nocccer linked an issue Feb 17, 2022 that may be closed by this pull request
Check for Updates On Startup does not toggle off #978
Closed
@Nocccer Nocccer changed the title [General] Fixed option check for update on startup [General] Fix option check for update on startup Feb 17, 2022
flavioislima
flavioislima approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here, looks good! 👍🏽

@flavioislima flavioislima merged commit 124ae40 into main Feb 23, 2022
@flavioislima flavioislima deleted the fix_option_update_notification branch February 23, 2022 19:01
@redromnon redromnon mentioned this pull request Apr 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for Updates On Startup does not toggle off
2 participants
@Nocccer @flavioislima