Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Use Steam Runtime with Proton #1296

Merged
merged 10 commits into from
May 21, 2022
Merged

[Linux] Use Steam Runtime with Proton #1296

merged 10 commits into from
May 21, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented May 12, 2022

Use SteamRuntime if available when using Proton.

  • Check if soldier is available and use it
  • if not, use scout

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:wip WIP, don't merge. label May 12, 2022
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runWineCommand also needs some changes to use the runtime there as well

electron/gog/games.ts Outdated Show resolved Hide resolved
@flavioislima flavioislima added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:wip WIP, don't merge. labels May 21, 2022
@flavioislima
Copy link
Member Author

@CommandMC I will leave the runWineCommand to another PR for now, but added a TODO for reminder.

@flavioislima flavioislima changed the title [Linux/UX] Use Steam Runtime with Proton [Linux] Use Steam Runtime with Proton May 21, 2022
@flavioislima flavioislima merged commit 405fe93 into main May 21, 2022
@flavioislima flavioislima deleted the steam_runtime_proton branch May 21, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants