[UI] Add accessibility option to show all game tiles in color #1311

connercsbn · 2022-05-15T10:40:58Z

Patch to address feature request #1301

This adds an option in accessibility settings that, when enabled, adds the allTilesInColor class to the GameCard component, making all tiles show in color.

Just wanted to get this out there and get some feedback. Will do checklist soon!

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)

arielj · 2022-05-15T13:28:16Z

src/screens/Accessibility/index.tsx

+                setAllTilesInColor(!allTilesInColor)
+              }}
+              title={t(
+                'accessibility.allTilesInColor',


Please use camel_case here accessibility.all_titles_in_color.

Also, please run yarn i18next after changing that so it updates all the locales for all languages.

connercsbn · 2022-05-16T07:04:17Z

Did something go wrong when I ran yarn i18next?

imLinguin · 2022-05-16T07:42:10Z

public/locales/fa/translation.json

    "library": {
-        "gridView": "نمای شبکه‌ای",
+        "gridView": "نمای شبکه\u200cای",


Could you remove this \u200c manually? this is i18n bug with languages like this

👍 3842ba3

flavioislima · 2022-05-16T08:52:28Z

public/locales/bg/gamepage.json

@@ -66,14 +64,6 @@
        "moving": "Преместване",
        "repairing": "Поправяне"
    },
-    "info": {


those removals doesnt seems right

that's what I was thinking, but that's what happens when I run yarn i18next, even on the up-to-date main branch

yarn i18next or yarn i18n? should be the same, I guess. But I will try to investigate this later.

flavioislima · 2022-05-16T09:01:27Z

Need to check why so many translations were deleted on this PR. I cannot find any change related to that, so we need to check main and run the command there to see whats happening because it is deleting a lot of keys from settings, gamepage, etc.

flavioislima · 2022-05-16T10:01:15Z

@arielj I believe that the missing keys are related to one of the refactors on the UI.
Some keys moved to a different file and then lost the translation.
Example: status.moving was on the gamepage.json but moved to translations.json and lost the value.
Maybe was when some components were moved. I dont know if this is breaking some language right now, but might be.
We should investigate that in another PR and try to move the keys around files, or maybe start using one single file for all translations.

arielj · 2022-05-16T11:13:56Z

Agree on using one single file for all the translations, since we don't really need to modify those files manually anyway, should simplify some code and allow re-usability

flavioislima · 2022-05-16T12:31:28Z

@arielj yes, that will be a lot of work, we have 64 translations file now, but will work best and it is better than losing all translations.

flavioislima · 2022-05-17T08:02:38Z

@connercsbn @arielj
Found the issue and it is simple to solve.
Just edit this line:

HeroicGamesLauncher/src/screens/Game/GamePage/index.tsx

Line 48 in cb7b475

const { t: t2 } = useTranslation('translation')

to put it like this:
const { t: t2 } = useTranslation()

and then run yarn i18n again. In case it doesnt fix it, try removing the folder locales and then run the command again. Should be fine.

The thing is that for the default file, that is translations.json we dont need to pass an argument, because it is the default.
I mean, the i18next should be able to catch that but it doesnt.

flavioislima · 2022-05-18T08:20:32Z

public/locales/en/translation.json

@@ -282,7 +286,6 @@
            "title": "Manual Sync Saves",
            "upload": "Upload"
        },
-        "maxRecentGames": "Played Recently to Show",


weird that it is still removing a few keys not related with the PR. 🤔

Ah, looks like it's caused by a couple deleted lines from here: 421ae61

Yes, you are right. Let me try to fix those

flavioislima · 2022-05-18T11:14:54Z

ok, fixed it in main. Try to update your branch now.
also tested the feature and it is working fine. :)

connercsbn

Seems like last thing I need to do is revert the deletion of these lines, since they're being generated in English for these translation files. I'll see if I can grab the files from the main branch and rerun i18n

flavioislima

Perfect! Thanks a lot for that! :D

arielj reviewed May 15, 2022

View reviewed changes

arielj linked an issue May 15, 2022 that may be closed by this pull request

[UI] option to show all game tiles in color instead of black and white #1301

Closed

imLinguin reviewed May 16, 2022

View reviewed changes

flavioislima reviewed May 16, 2022

View reviewed changes

connercsbn added 4 commits May 17, 2022 03:27

add accessibility option to show all game tiles in color

151046c

rename i18n variable

d8e3bc9

fix useTranslate line

ad43ae2

run yarn i18n

d1ee724

connercsbn force-pushed the show-all-tiles-in-color branch from 60b387e to d1ee724 Compare May 17, 2022 10:32

remove \u200c

3a60588

flavioislima added the pr:testing This PR is in testing, don't merge. label May 18, 2022

flavioislima reviewed May 18, 2022

View reviewed changes

flavioislima changed the title ~~add accessibility option to show all game tiles in color~~ [UI] Add accessibility option to show all game tiles in color May 18, 2022

connercsbn added 2 commits May 18, 2022 05:34

merge main

a90cc96

run yarn i18n

f51f25e

connercsbn commented May 18, 2022

View reviewed changes

connercsbn added 3 commits May 18, 2022 05:54

grab translation files from main branch

4fa88fe

run yarn i18n

82128f2

remove \u200c

5df308a

flavioislima approved these changes May 18, 2022

View reviewed changes

flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:testing This PR is in testing, don't merge. labels May 18, 2022

flavioislima merged commit b738081 into Heroic-Games-Launcher:main May 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI] Add accessibility option to show all game tiles in color #1311

[UI] Add accessibility option to show all game tiles in color #1311

connercsbn commented May 15, 2022 •

edited

Loading

arielj May 15, 2022

connercsbn commented May 16, 2022

imLinguin May 16, 2022

connercsbn May 16, 2022

flavioislima May 16, 2022

connercsbn May 16, 2022

flavioislima May 16, 2022

flavioislima commented May 16, 2022

flavioislima commented May 16, 2022 •

edited

Loading

arielj commented May 16, 2022

flavioislima commented May 16, 2022

flavioislima commented May 17, 2022

flavioislima May 18, 2022

connercsbn May 18, 2022

flavioislima May 18, 2022

flavioislima commented May 18, 2022

connercsbn left a comment

flavioislima left a comment

[UI] Add accessibility option to show all game tiles in color #1311

[UI] Add accessibility option to show all game tiles in color #1311

Conversation

connercsbn commented May 15, 2022 • edited Loading

Choose a reason for hiding this comment

connercsbn commented May 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flavioislima commented May 16, 2022

flavioislima commented May 16, 2022 • edited Loading

arielj commented May 16, 2022

flavioislima commented May 16, 2022

flavioislima commented May 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flavioislima commented May 18, 2022

connercsbn left a comment

Choose a reason for hiding this comment

flavioislima left a comment

Choose a reason for hiding this comment

connercsbn commented May 15, 2022 •

edited

Loading

flavioislima commented May 16, 2022 •

edited

Loading