Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Check for game updates before launch #1335

Merged
merged 3 commits into from
May 18, 2022
Merged

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented May 18, 2022

This fixes the issue we are having now where it is not possible to skip an update when launching a game.
I changed the logic to check the update on frontend and show the message before even launching the game instead of waiting for an error from Legendary.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 18, 2022
src/helpers/library.ts Outdated Show resolved Hide resolved
electron/legendary/games.ts Outdated Show resolved Hide resolved
@flavioislima flavioislima merged commit 3cf1c76 into main May 18, 2022
@flavioislima flavioislima deleted the fix_update_check branch May 18, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants