[UI] Show if there is enough space available on Install #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
added
the
pr:ready-for-review
arielj
reviewed
May 19, 2022
electron/main.ts
Outdated
| const { free, size: diskSize } = await checkDiskSpace(folder) | ||
| return `${getFileSize(free)}/${getFileSize(diskSize)}` | ||
| ipcMain.handle('checkDiskSpace', async (event, folder: string) => { | ||
| if (folder.startsWith('/')) { |
There was a problem hiding this comment.
just wondering, does this work on windows? looks like unix specific
There was a problem hiding this comment.
yes, won't work. I will figure out another way of checking that.
There was a problem hiding this comment.
So actualy the function checkDiskSpace checks if the path is valid based on the platform so we dont need to do it ourselves.
So I just changed it to a try catch now.
arielj
reviewed
May 19, 2022
…uncher into fix_space_check
…uncher into fix_space_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the error handler on the backend but the main check now is on the frontend.
I will check if there enough space and if the path is writable, if not, then the Install Button will be disabled.
Linux/Mac
Windows:
Use the following Checklist if you have changed something on the Backend or Frontend: