Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new --no-gui parameter #1362

Merged
merged 4 commits into from
May 24, 2022
Merged

Conversation

CommandMC
Copy link
Collaborator

Launching Heroic without the UI is now possible with this parameter. Together with launching a game (heroic://launch/AppName), this now allows for a fully headless game launch, similar to HBL (HBL's still faster, since we have to load all of Heroic first)

Closes #1361


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label May 23, 2022
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels May 23, 2022
@flavioislima
Copy link
Member

Need to test but looks good codewise.
Also, --no-gui sounds better maybe?
Because I know that other software use the --gui, protontricks for instance.
although doesn't really matter once we document it or add a cli --help

@CommandMC
Copy link
Collaborator Author

I agree, I'll change it to --no-gui. Just took it directly from the issue

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works pretty good. I liked it that it closes Heroic after the game closes. This will probably be useful then adding heroic on other tools :)

@lublak
Copy link

lublak commented May 24, 2022

Whether it's --no-ui or --no-gui or --please-dont-show-a-graphical-user-interface. I'm fine with anything.
Whereas "gui" in linguistic usage is mostly used for the interface. Rather more rarely just "ui".

@CommandMC CommandMC changed the title Add new --no-ui parameter Add new --no-gui parameter May 24, 2022
@CommandMC CommandMC merged commit f10051f into Heroic-Games-Launcher:main May 24, 2022
@CommandMC CommandMC deleted the hide-ui branch May 24, 2022 09:39
@rkr87
Copy link

rkr87 commented May 25, 2022

Did this make it into 2.3.3?

@lublak
Copy link

lublak commented May 25, 2022

@rkr87 the 2.3.3 build is 4 days ago but the feature is merged yesterday. Soooo it think not.

@rkr87
Copy link

rkr87 commented May 25, 2022

The Flatpak release of 2.3.3 only became available today on Flathub. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow run a game without ui
4 participants