Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup verifyWinePrefix for Proton... again #1388

Merged
merged 1 commit into from
May 28, 2022

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 27, 2022

Proton copies over a ready-made default prefix when it detects that it needs to update, so running wineboot afterwards will always say that it wasn't updated. This changes verifyWinePrefix so it (1) returns early if a Proton prefix is already present & (2) returns true if Proton created a prefix

This is still somewhat naive since it relies on the pfx directory (not) being present, but it's still better than not working at all


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested a review from imLinguin May 27, 2022 15:53
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 27, 2022
@flavioislima flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels May 28, 2022
@CommandMC CommandMC merged commit 9d4912a into Heroic-Games-Launcher:main May 28, 2022
@CommandMC CommandMC deleted the fix-wineboot-proton branch May 28, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants